Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8250627: Use -XX:+/-UseContainerSupport for enabling/disabling Java container metrics #38

Closed
wants to merge 1 commit into from

Conversation

@kvergizova
Copy link
Contributor

@kvergizova kvergizova commented Nov 27, 2020

I would like to backport 8250627 to 13u for parity with 11u.
The patch doesn't apply cleanly since 13u doesn't have cgroups v2 support (JDK-8231111), reapplied manually.
Tested with container tests, including new one and tier1.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8250627: Use -XX:+/-UseContainerSupport for enabling/disabling Java container metrics

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk13u-dev pull/38/head:pull/38
$ git checkout pull/38

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Nov 27, 2020

👋 Welcome back evergizova! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport e6517d1ae2628f16442e09fd8f48190762517d2e 8250627: Use -XX:+/-UseContainerSupport for enabling/disabling Java container metrics Nov 27, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Nov 27, 2020

This backport pull request has now been updated with issue from the original commit.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Nov 27, 2020

Webrevs

@yan-too
yan-too approved these changes Dec 3, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Dec 3, 2020

@kvergizova This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8250627: Use -XX:+/-UseContainerSupport for enabling/disabling Java container metrics

Reviewed-by: yan

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 6 new commits pushed to the master branch:

  • 28cc6c2: 8254982: (tz) Upgrade time-zone data to tzdata2020c
  • b31ff27: 8254177: (tz) Upgrade time-zone data to tzdata2020b
  • b452c82: 8233228: Disable weak named curves by default in TLS, CertPath, and Signed JAR
  • 420ec53: 8230402: Allocation of compile task fails with assert: "Leaking compilation tasks?"
  • 74991c9: 8233958: Memory retention due to HttpsURLConnection finalizer that serves no purpose
  • dabaf4e: 8235183: Remove the "HACK CODE" in comment

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@yan-too) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready label Dec 3, 2020
@kvergizova
Copy link
Contributor Author

@kvergizova kvergizova commented Dec 4, 2020

/integrate

@openjdk openjdk bot added the sponsor label Dec 4, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Dec 4, 2020

@kvergizova
Your change (at version 8547197) is now ready to be sponsored by a Committer.

@yan-too
Copy link
Collaborator

@yan-too yan-too commented Dec 4, 2020

/sponsor

@openjdk openjdk bot closed this Dec 4, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Dec 4, 2020

@yan-too @kvergizova Since your change was applied there have been 6 commits pushed to the master branch:

  • 28cc6c2: 8254982: (tz) Upgrade time-zone data to tzdata2020c
  • b31ff27: 8254177: (tz) Upgrade time-zone data to tzdata2020b
  • b452c82: 8233228: Disable weak named curves by default in TLS, CertPath, and Signed JAR
  • 420ec53: 8230402: Allocation of compile task fails with assert: "Leaking compilation tasks?"
  • 74991c9: 8233958: Memory retention due to HttpsURLConnection finalizer that serves no purpose
  • dabaf4e: 8235183: Remove the "HACK CODE" in comment

Your commit was automatically rebased without conflicts.

Pushed as commit 18bd8e2.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@kvergizova kvergizova deleted the kvergizova:backport-8250627 branch Dec 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants