Skip to content
This repository has been archived by the owner on Feb 2, 2023. It is now read-only.
/ jdk13u-dev Public archive

8257569: Failure observed with JfrVirtualMemory::initialize #383

Closed
wants to merge 1 commit into from

Conversation

kvergizova
Copy link
Contributor

@kvergizova kvergizova commented Jul 29, 2022

I'd like to backport JDK-8257569 to 13u for parity with 11u.
The patch applies cleanly.
Tested with jdk/jfr and tier1 tests.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8257569: Failure observed with JfrVirtualMemory::initialize

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk13u-dev pull/383/head:pull/383
$ git checkout pull/383

Update a local copy of the PR:
$ git checkout pull/383
$ git pull https://git.openjdk.org/jdk13u-dev pull/383/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 383

View PR using the GUI difftool:
$ git pr show -t 383

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk13u-dev/pull/383.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 29, 2022

👋 Welcome back evergizova! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport f0bd9db5c763a742b5641e2b70f0c49f19d1d768 8257569: Failure observed with JfrVirtualMemory::initialize Jul 29, 2022
@openjdk
Copy link

openjdk bot commented Jul 29, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Jul 29, 2022

@kvergizova This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8257569: Failure observed with JfrVirtualMemory::initialize

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • e5ddcb1: 8272806: [macOS] "Apple AWT Internal Exception" when input method is changed

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 29, 2022
@mlbridge
Copy link

mlbridge bot commented Jul 29, 2022

Webrevs

@kvergizova
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Jul 29, 2022

Going to push as commit 052091a.
Since your change was applied there have been 2 commits pushed to the master branch:

  • 9df60c0: 8264792: The NumberFormat for locale sq_XK formats price incorrectly.
  • e5ddcb1: 8272806: [macOS] "Apple AWT Internal Exception" when input method is changed

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jul 29, 2022
@openjdk openjdk bot closed this Jul 29, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 29, 2022
@openjdk
Copy link

openjdk bot commented Jul 29, 2022

@kvergizova Pushed as commit 052091a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport clean integrated Pull request has been integrated
1 participant