Skip to content
This repository has been archived by the owner on Feb 2, 2023. It is now read-only.

8289549: ISO 4217 Amendment 172 Update #388

Closed
wants to merge 1 commit into from

Conversation

yan-too
Copy link
Collaborator

@yan-too yan-too commented Aug 16, 2022

I'm backporting this recurrent change to be on par with most other releases.
The only difference from original is, CurrencyData.properties is still in make/data subdirectory.
All relevant tests run fine.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk13u-dev pull/388/head:pull/388
$ git checkout pull/388

Update a local copy of the PR:
$ git checkout pull/388
$ git pull https://git.openjdk.org/jdk13u-dev pull/388/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 388

View PR using the GUI difftool:
$ git pr show -t 388

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk13u-dev/pull/388.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 16, 2022

👋 Welcome back yan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 604ea90d55ac8354fd7287490ef59b8e3ce020d1 8289549: ISO 4217 Amendment 172 Update Aug 16, 2022
@openjdk
Copy link

openjdk bot commented Aug 16, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Aug 16, 2022
@mlbridge
Copy link

mlbridge bot commented Aug 16, 2022

Webrevs

@openjdk
Copy link

openjdk bot commented Aug 16, 2022

@yan-too This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8289549: ISO 4217 Amendment 172 Update

Reviewed-by: dcherepanov

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Aug 16, 2022
@yan-too
Copy link
Collaborator Author

yan-too commented Aug 16, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Aug 16, 2022

Going to push as commit d9202d6.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 16, 2022
@openjdk openjdk bot closed this Aug 16, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 16, 2022
@openjdk
Copy link

openjdk bot commented Aug 16, 2022

@yan-too Pushed as commit d9202d6.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@yan-too yan-too deleted the bp8289549 branch August 16, 2022 10:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport integrated Pull request has been integrated
2 participants