Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8233958: Memory retention due to HttpsURLConnection finalizer that serves no purpose #39

Closed
wants to merge 1 commit into from

Conversation

@yan-too
Copy link
Collaborator

@yan-too yan-too commented Nov 30, 2020

Should be downported here, too. The patch applies clean. Tier[123] tests pass.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8233958: Memory retention due to HttpsURLConnection finalizer that serves no purpose

Download

$ git fetch https://git.openjdk.java.net/jdk13u-dev pull/39/head:pull/39
$ git checkout pull/39

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Nov 30, 2020

👋 Welcome back yan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

@openjdk openjdk bot changed the title Backport 9f91b8dde2be4fbcebdde938c4ef017921c5c203 8233958: Memory retention due to HttpsURLConnection finalizer that serves no purpose Nov 30, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Nov 30, 2020

This backport pull request has now been updated with issue from the original commit.

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Nov 30, 2020

@yan-too This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8233958: Memory retention due to HttpsURLConnection finalizer that serves no purpose

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

Loading

@yan-too
Copy link
Collaborator Author

@yan-too yan-too commented Nov 30, 2020

/integrate

Loading

@openjdk openjdk bot closed this Nov 30, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Nov 30, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Nov 30, 2020

@yan-too Pushed as commit 74991c9.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Loading

@mlbridge
Copy link

@mlbridge mlbridge bot commented Nov 30, 2020

Webrevs

Loading

@yan-too yan-too deleted the bp8233958 branch Nov 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant