Skip to content
This repository has been archived by the owner on Feb 2, 2023. It is now read-only.

8282947: JFR: Dump on shutdown live-locks in some conditions #395

Closed
wants to merge 1 commit into from

Conversation

kvergizova
Copy link
Contributor

@kvergizova kvergizova commented Aug 26, 2022

I'd like to backport JDK-8282947 to 13u for parity with 11u.
The patch applies cleanly.
Tested with jdk/jfr and tier1 tests; added test fails without the patch and passes with it on Linux.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8282947: JFR: Dump on shutdown live-locks in some conditions

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk13u-dev pull/395/head:pull/395
$ git checkout pull/395

Update a local copy of the PR:
$ git checkout pull/395
$ git pull https://git.openjdk.org/jdk13u-dev pull/395/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 395

View PR using the GUI difftool:
$ git pr show -t 395

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk13u-dev/pull/395.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 26, 2022

👋 Welcome back evergizova! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 63eb0b7e8606dd9cd145e92eeeb744ff5b7be569 8282947: JFR: Dump on shutdown live-locks in some conditions Aug 26, 2022
@openjdk
Copy link

openjdk bot commented Aug 26, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Aug 26, 2022

@kvergizova This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8282947: JFR: Dump on shutdown live-locks in some conditions

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 5 new commits pushed to the master branch:

  • bd0ca30: 8283441: C2: segmentation fault in ciMethodBlocks::make_block_at(int)
  • cab6b37: 7131823: bug in GIFImageReader
  • 09da466: 8286594: (zipfs) Mention paths with dot elements in ZipException and cleanups
  • 1e900ac: 8282071: Update java.xml module-info
  • 8b0b375: 8261354: SIGSEGV at MethodIteratorHost

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 26, 2022
@mlbridge
Copy link

mlbridge bot commented Aug 26, 2022

Webrevs

@kvergizova
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Aug 29, 2022

Going to push as commit 0292f8a.
Since your change was applied there have been 5 commits pushed to the master branch:

  • bd0ca30: 8283441: C2: segmentation fault in ciMethodBlocks::make_block_at(int)
  • cab6b37: 7131823: bug in GIFImageReader
  • 09da466: 8286594: (zipfs) Mention paths with dot elements in ZipException and cleanups
  • 1e900ac: 8282071: Update java.xml module-info
  • 8b0b375: 8261354: SIGSEGV at MethodIteratorHost

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 29, 2022
@openjdk openjdk bot closed this Aug 29, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 29, 2022
@openjdk
Copy link

openjdk bot commented Aug 29, 2022

@kvergizova Pushed as commit 0292f8a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport clean integrated Pull request has been integrated
1 participant