Skip to content
This repository has been archived by the owner on Feb 2, 2023. It is now read-only.
/ jdk13u-dev Public archive

8268361: Fix the infinite loop in next_line #397

Closed
wants to merge 1 commit into from

Conversation

wkia
Copy link

@wkia wkia commented Sep 1, 2022

Backport of JDK-8268361 to 13u.
It needs to be ported due to similar problems as 17u has.
Fix applies cleanly. Tests tier1 passed after the fix without regression.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk13u-dev pull/397/head:pull/397
$ git checkout pull/397

Update a local copy of the PR:
$ git checkout pull/397
$ git pull https://git.openjdk.org/jdk13u-dev pull/397/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 397

View PR using the GUI difftool:
$ git pr show -t 397

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk13u-dev/pull/397.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 1, 2022

👋 Welcome back wkia! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 72672277e4dddf8e72f1c705cd5f57de40745635 8268361: Fix the infinite loop in next_line Sep 1, 2022
@openjdk
Copy link

openjdk bot commented Sep 1, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Sep 1, 2022

@wkia This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8268361: Fix the infinite loop in next_line

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 1, 2022
@mlbridge
Copy link

mlbridge bot commented Sep 1, 2022

Webrevs

@wkia
Copy link
Author

wkia commented Sep 1, 2022

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Sep 1, 2022
@openjdk
Copy link

openjdk bot commented Sep 1, 2022

@wkia
Your change (at version ca7da93) is now ready to be sponsored by a Committer.

@yan-too
Copy link
Collaborator

yan-too commented Sep 1, 2022

/sponsor

@openjdk
Copy link

openjdk bot commented Sep 1, 2022

Going to push as commit 97c75f0.

@openjdk openjdk bot added the integrated Pull request has been integrated label Sep 1, 2022
@openjdk openjdk bot closed this Sep 1, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Sep 1, 2022
@wkia wkia deleted the backport-72672277 branch September 1, 2022 12:21
@openjdk
Copy link

openjdk bot commented Sep 1, 2022

@yan-too @wkia Pushed as commit 97c75f0.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants