Skip to content
This repository has been archived by the owner on Feb 2, 2023. It is now read-only.
/ jdk13u-dev Public archive

8272472: StackGuardPages test doesn't build with glibc 2.34 #407

Closed
wants to merge 1 commit into from

Conversation

yan-too
Copy link
Collaborator

@yan-too yan-too commented Sep 16, 2022

a simple test fix necessary to build test-image.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8272472: StackGuardPages test doesn't build with glibc 2.34

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk13u-dev pull/407/head:pull/407
$ git checkout pull/407

Update a local copy of the PR:
$ git checkout pull/407
$ git pull https://git.openjdk.org/jdk13u-dev pull/407/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 407

View PR using the GUI difftool:
$ git pr show -t 407

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk13u-dev/pull/407.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 16, 2022

👋 Welcome back yan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport f77a1a156f3da9068d012d9227c7ee0fee58f571 8272472: StackGuardPages test doesn't build with glibc 2.34 Sep 16, 2022
@openjdk
Copy link

openjdk bot commented Sep 16, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Sep 16, 2022

@yan-too This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8272472: StackGuardPages test doesn't build with glibc 2.34

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 7e5b8d3: 8266172: -Wstringop-overflow happens in vmError.cpp

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 16, 2022
@mlbridge
Copy link

mlbridge bot commented Sep 16, 2022

Webrevs

@yan-too
Copy link
Collaborator Author

yan-too commented Sep 16, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Sep 16, 2022

Going to push as commit 6449dfb.
Since your change was applied there has been 1 commit pushed to the master branch:

  • 7e5b8d3: 8266172: -Wstringop-overflow happens in vmError.cpp

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Sep 16, 2022
@openjdk openjdk bot closed this Sep 16, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 16, 2022
@openjdk
Copy link

openjdk bot commented Sep 16, 2022

@yan-too Pushed as commit 6449dfb.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@yan-too yan-too deleted the bp8272472 branch September 16, 2022 08:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant