Skip to content
This repository has been archived by the owner on Feb 2, 2023. It is now read-only.
/ jdk13u-dev Public archive

8242565: Policy initialization issues when the denyAfter constraint is enabled #416

Closed
wants to merge 1 commit into from

Conversation

alexeybakhtin
Copy link
Contributor

@alexeybakhtin alexeybakhtin commented Oct 10, 2022

Almost clean backports instead of copyright year in the KeyStoreUtil.java and SignedJarTest.java

java/security tests passed


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8242565: Policy initialization issues when the denyAfter constraint is enabled

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk13u-dev pull/416/head:pull/416
$ git checkout pull/416

Update a local copy of the PR:
$ git checkout pull/416
$ git pull https://git.openjdk.org/jdk13u-dev pull/416/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 416

View PR using the GUI difftool:
$ git pr show -t 416

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk13u-dev/pull/416.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 10, 2022

👋 Welcome back abakhtin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 3efd000036d276c73f3be83d1cb4a7c6da08d3e8 8242565: Policy initialization issues when the denyAfter constraint is enabled Oct 10, 2022
@openjdk
Copy link

openjdk bot commented Oct 10, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Oct 10, 2022
@mlbridge
Copy link

mlbridge bot commented Oct 10, 2022

Webrevs

Copy link
Collaborator

@yan-too yan-too left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine, thank you! I guess you could label it jdk13u-critical-request to have in October here, too.

@openjdk
Copy link

openjdk bot commented Oct 10, 2022

@alexeybakhtin This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8242565: Policy initialization issues when the denyAfter constraint is enabled

Reviewed-by: yan, vkempik

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Oct 10, 2022
@alexeybakhtin
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Oct 10, 2022

Going to push as commit ff31243.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 10, 2022
@openjdk openjdk bot closed this Oct 10, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 10, 2022
@openjdk
Copy link

openjdk bot commented Oct 10, 2022

@alexeybakhtin Pushed as commit ff31243.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

3 participants