Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8231968: getCurrentThreadAllocatedBytes default implementation s/b getThreadAllocatedBytes #47

Closed
wants to merge 1 commit into from

Conversation

kvergizova
Copy link
Contributor

@kvergizova kvergizova commented Dec 4, 2020

I'd like to backport 8231968 to 13u as follow-up fix for JDK-8231209 that is already included to 13u.
CSR for 13u is approved: JDK-8257410.
The patch applies cleanly.
Tested with ThreadMXBean tests and tier1.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8231968: getCurrentThreadAllocatedBytes default implementation s/b getThreadAllocatedBytes

Download

$ git fetch https://git.openjdk.java.net/jdk13u-dev pull/47/head:pull/47
$ git checkout pull/47

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 4, 2020

👋 Welcome back evergizova! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 68e5c40f6f0f42a893595d2a3ecbebcd81742543 8231968: getCurrentThreadAllocatedBytes default implementation s/b getThreadAllocatedBytes Dec 4, 2020
@openjdk
Copy link

openjdk bot commented Dec 4, 2020

This backport pull request has now been updated with issue and summary from the original commit.

@openjdk
Copy link

openjdk bot commented Dec 4, 2020

@kvergizova This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8231968: getCurrentThreadAllocatedBytes default implementation s/b getThreadAllocatedBytes

Pass Thread.currentThread().getId() to getThreadAllocatedBytes, remove its implSpec

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 4881f8e: 8246648: issue with OperatingSystemImpl getFreeSwapSpaceSize in docker after 8242480

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 4, 2020
@mlbridge
Copy link

mlbridge bot commented Dec 4, 2020

Webrevs

@kvergizova
Copy link
Contributor Author

kvergizova commented Dec 4, 2020

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Dec 4, 2020
@openjdk
Copy link

openjdk bot commented Dec 4, 2020

@kvergizova
Your change (at version e2a6e8a) is now ready to be sponsored by a Committer.

@yan-too
Copy link
Collaborator

yan-too commented Dec 4, 2020

/sponsor

@openjdk openjdk bot closed this Dec 4, 2020
@openjdk openjdk bot added integrated Pull request has been integrated and removed sponsor Pull request is ready to be sponsored ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 4, 2020
@openjdk
Copy link

openjdk bot commented Dec 4, 2020

@yan-too @kvergizova Since your change was applied there has been 1 commit pushed to the master branch:

  • 4881f8e: 8246648: issue with OperatingSystemImpl getFreeSwapSpaceSize in docker after 8242480

Your commit was automatically rebased without conflicts.

Pushed as commit e22699c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@kvergizova kvergizova deleted the backport-8231968 branch Dec 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
2 participants