Skip to content
This repository has been archived by the owner on Feb 2, 2023. It is now read-only.

8240197: Cannot start JVM when $JAVA_HOME includes CJK characters #49

Closed
wants to merge 1 commit into from
Closed

8240197: Cannot start JVM when $JAVA_HOME includes CJK characters #49

wants to merge 1 commit into from

Conversation

omikhaltsova
Copy link
Contributor

@omikhaltsova omikhaltsova commented Dec 6, 2020

I'd like to backport JDK-8240197 to jdk13u for parity with jdk11u.
The original patch applied cleanly.
Tested with tier1, tier2, tier3. No regression in tests.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8240197: Cannot start JVM when $JAVA_HOME includes CJK characters

Download

$ git fetch https://git.openjdk.java.net/jdk13u-dev pull/49/head:pull/49
$ git checkout pull/49

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 6, 2020

👋 Welcome back omikhaltcova! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 3490262a6b8e684673966e5aa63578ccfeae5da1 8240197: Cannot start JVM when $JAVA_HOME includes CJK characters Dec 6, 2020
@openjdk
Copy link

openjdk bot commented Dec 6, 2020

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Dec 6, 2020

@omikhaltsova This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8240197: Cannot start JVM when $JAVA_HOME includes CJK characters

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 6, 2020
@mlbridge
Copy link

mlbridge bot commented Dec 6, 2020

Webrevs

@omikhaltsova
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Dec 6, 2020
@openjdk
Copy link

openjdk bot commented Dec 6, 2020

@omikhaltsova
Your change (at version 777b310) is now ready to be sponsored by a Committer.

@yan-too
Copy link
Collaborator

yan-too commented Dec 6, 2020

/sponsor

@openjdk openjdk bot closed this Dec 6, 2020
@openjdk openjdk bot added integrated Pull request has been integrated and removed sponsor Pull request is ready to be sponsored ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 6, 2020
@openjdk
Copy link

openjdk bot commented Dec 6, 2020

@yan-too @omikhaltsova Pushed as commit 6456cad.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport clean integrated Pull request has been integrated
2 participants