Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8232616: JVMCI_lock fails to get initialized when cds is disabled #5

Closed
wants to merge 1 commit into from

Conversation

@VladimirKempik
Copy link
Contributor

@VladimirKempik VladimirKempik commented Oct 27, 2020

Please review this backport of 8232616 to jdk13u, fix didn't apply cleanly, minimal mods were needed.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8232616: JVMCI_lock fails to get initialized when cds is disabled

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk13u-dev pull/5/head:pull/5
$ git checkout pull/5

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Oct 27, 2020

👋 Welcome back vkempik! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

@openjdk openjdk bot added the rfr label Oct 27, 2020
@mlbridge
Copy link

@mlbridge mlbridge bot commented Oct 27, 2020

Webrevs

Loading

Copy link
Collaborator

@yan-too yan-too left a comment

so it is slightly different context here, OK...

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Oct 27, 2020

@VladimirKempik This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8232616: JVMCI_lock fails to get initialized when cds is disabled

Reviewed-by: yan

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

Loading

@openjdk openjdk bot added the ready label Oct 27, 2020
@VladimirKempik
Copy link
Contributor Author

@VladimirKempik VladimirKempik commented Oct 27, 2020

/integrate

Loading

@openjdk openjdk bot closed this Oct 27, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Oct 27, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Oct 27, 2020

@VladimirKempik Pushed as commit 8ea6f9e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Loading

@VladimirKempik VladimirKempik deleted the JDK-8232616 branch Jan 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants