Skip to content
This repository has been archived by the owner on Feb 2, 2023. It is now read-only.

8248347: windows build broken by JDK-8243114 #58

Closed
wants to merge 1 commit into from

Conversation

kvergizova
Copy link
Contributor

@kvergizova kvergizova commented Dec 11, 2020

I would like to backport 8248347 to 13u as follow-up fix for 8243114 that is already included to 13.
The patch applies cleanly.
Debug configurations are built successfully after applying the patch.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

Download

$ git fetch https://git.openjdk.java.net/jdk13u-dev pull/58/head:pull/58
$ git checkout pull/58

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 11, 2020

👋 Welcome back evergizova! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport b87302ca99ff30a03e311ab1c0f524684ed37596 8248347: windows build broken by JDK-8243114 Dec 11, 2020
@openjdk
Copy link

openjdk bot commented Dec 11, 2020

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Dec 11, 2020

@kvergizova This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8248347: windows build broken by JDK-8243114

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 11, 2020
@mlbridge
Copy link

mlbridge bot commented Dec 11, 2020

Webrevs

@kvergizova
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Dec 11, 2020
@openjdk
Copy link

openjdk bot commented Dec 11, 2020

@kvergizova
Your change (at version 31fa6db) is now ready to be sponsored by a Committer.

@yan-too
Copy link
Collaborator

yan-too commented Dec 11, 2020

/sponsor

@openjdk openjdk bot closed this Dec 11, 2020
@openjdk openjdk bot added integrated Pull request has been integrated and removed sponsor Pull request is ready to be sponsored ready Pull request is ready to be integrated labels Dec 11, 2020
@openjdk
Copy link

openjdk bot commented Dec 11, 2020

@yan-too @kvergizova Pushed as commit b7937d8.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@openjdk openjdk bot removed the rfr Pull request is ready for review label Dec 11, 2020
@kvergizova kvergizova deleted the backport-8248347 branch December 22, 2020 19:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport clean integrated Pull request has been integrated
2 participants