Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8239886: Minimal VM build fails after JDK-8237499 #63

Closed
wants to merge 1 commit into from

Conversation

kvergizova
Copy link
Contributor

@kvergizova kvergizova commented Dec 18, 2020

I'd like to backport 8239886 to 13u as follow-up fix for JDK-8237499 that is already included to 13u.
The patch applies cleanly.
Minimal VM variant are built successfully after applying the patch.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8239886: Minimal VM build fails after JDK-8237499

Download

$ git fetch https://git.openjdk.java.net/jdk13u-dev pull/63/head:pull/63
$ git checkout pull/63

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 18, 2020

👋 Welcome back evergizova! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 5a7b5863f0ac34f73496913b4319e73f1eb47e73 8239886: Minimal VM build fails after JDK-8237499 Dec 18, 2020
@openjdk
Copy link

openjdk bot commented Dec 18, 2020

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Dec 18, 2020

@kvergizova This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8239886: Minimal VM build fails after JDK-8237499

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 18, 2020
@mlbridge
Copy link

mlbridge bot commented Dec 18, 2020

Webrevs

@kvergizova
Copy link
Contributor Author

kvergizova commented Dec 18, 2020

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Dec 18, 2020
@openjdk
Copy link

openjdk bot commented Dec 18, 2020

@kvergizova
Your change (at version 7ec7363) is now ready to be sponsored by a Committer.

@dimitryc
Copy link
Collaborator

dimitryc commented Dec 18, 2020

/sponsor

@openjdk openjdk bot closed this Dec 18, 2020
@openjdk openjdk bot added integrated Pull request has been integrated and removed sponsor Pull request is ready to be sponsored ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 18, 2020
@openjdk
Copy link

openjdk bot commented Dec 18, 2020

@dimitryc @kvergizova Pushed as commit 05ac56a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@kvergizova kvergizova deleted the backport-8239886 branch Dec 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
2 participants