Skip to content
This repository was archived by the owner on Feb 2, 2023. It is now read-only.
/ jdk13u-dev Public archive

8248532: Every time I change keyboard language at my MacBook, Java crashes #64

Closed
wants to merge 1 commit into from

Conversation

omikhaltsova
Copy link
Contributor

@omikhaltsova omikhaltsova commented Dec 21, 2020

I'd like to backport JDK-8248532 to jdk13u for parity with jdk11u.
The original patch applied cleanly.
Tested with jtreg:test/jdk:jdk_awt. No regression in tests.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8248532: Every time I change keyboard language at my MacBook, Java crashes

Download

$ git fetch https://git.openjdk.java.net/jdk13u-dev pull/64/head:pull/64
$ git checkout pull/64

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 21, 2020

👋 Welcome back omikhaltcova! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 6329de45045da3ce937cd22d82e74c3f142ea3f2 8248532: Every time I change keyboard language at my MacBook, Java crashes Dec 21, 2020
@openjdk
Copy link

openjdk bot commented Dec 21, 2020

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Dec 21, 2020

@omikhaltsova This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8248532: Every time I change keyboard language at my MacBook, Java crashes

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

  • 05ac56a: 8239886: Minimal VM build fails after JDK-8237499
  • 85b7908: 8237499: JFR: Include stack trace in the ThreadStart event
  • 20251b7: 8247867: Upgrade to freetype 2.10.2

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 21, 2020
@mlbridge
Copy link

mlbridge bot commented Dec 21, 2020

Webrevs

@omikhaltsova
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Dec 21, 2020
@openjdk
Copy link

openjdk bot commented Dec 21, 2020

@omikhaltsova
Your change (at version 24c630f) is now ready to be sponsored by a Committer.

@dimitryc
Copy link
Collaborator

Looks good. We'll also need to backport 8257242.

@dimitryc
Copy link
Collaborator

/sponsor

@openjdk openjdk bot closed this Dec 21, 2020
@openjdk openjdk bot added integrated Pull request has been integrated and removed sponsor Pull request is ready to be sponsored ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 21, 2020
@openjdk
Copy link

openjdk bot commented Dec 21, 2020

@dimitryc @omikhaltsova Since your change was applied there have been 3 commits pushed to the master branch:

  • 05ac56a: 8239886: Minimal VM build fails after JDK-8237499
  • 85b7908: 8237499: JFR: Include stack trace in the ThreadStart event
  • 20251b7: 8247867: Upgrade to freetype 2.10.2

Your commit was automatically rebased without conflicts.

Pushed as commit 501e942.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@omikhaltsova omikhaltsova deleted the backport-6329de45 branch January 22, 2021 13:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants