Navigation Menu

Skip to content
This repository has been archived by the owner on Feb 2, 2023. It is now read-only.

8252090: JFR: StreamWriterHost::write_unbuffered() stucks in an infinite loop OpenJDK (build 13.0.1+9) #66

Closed
wants to merge 1 commit into from

Conversation

kvergizova
Copy link
Contributor

@kvergizova kvergizova commented Dec 21, 2020

I'd like to backport 8252090 to 13u for parity with 11u.
The patch doesn't apply cleanly due to multiple context differences in jfrChunkWriter.cpp, reapplied manually.
Additionally 13u doesn't have JfrChunkHeadWriter::write_magic() method (JDK-8226511 is not in 13u), the corresponding changes are applied to JfrChunkWriter::open().
Tested with tier1 and jdk/jfr.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8252090: JFR: StreamWriterHost::write_unbuffered() stucks in an infinite loop OpenJDK (build 13.0.1+9)

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk13u-dev pull/66/head:pull/66
$ git checkout pull/66

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 21, 2020

👋 Welcome back evergizova! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 9924c45faebdba4084c9a5dd5b415dfe6c979024 8252090: JFR: StreamWriterHost::write_unbuffered() stucks in an infinite loop OpenJDK (build 13.0.1+9) Dec 21, 2020
@openjdk
Copy link

openjdk bot commented Dec 21, 2020

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Dec 21, 2020
@mlbridge
Copy link

mlbridge bot commented Dec 21, 2020

Webrevs

@openjdk
Copy link

openjdk bot commented Dec 21, 2020

@kvergizova This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8252090: JFR: StreamWriterHost::write_unbuffered() stucks in an infinite loop OpenJDK (build 13.0.1+9)

Reviewed-by: dcherepanov

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 5 new commits pushed to the master branch:

  • 92aec52: 8245400: Upgrade to LittleCMS 2.11
  • 501e942: 8248532: Every time I change keyboard language at my MacBook, Java crashes
  • 05ac56a: 8239886: Minimal VM build fails after JDK-8237499
  • 85b7908: 8237499: JFR: Include stack trace in the ThreadStart event
  • 20251b7: 8247867: Upgrade to freetype 2.10.2

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@dimitryc) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Dec 21, 2020
@kvergizova
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Dec 21, 2020
@openjdk
Copy link

openjdk bot commented Dec 21, 2020

@kvergizova
Your change (at version 7a0b703) is now ready to be sponsored by a Committer.

@dimitryc
Copy link
Collaborator

/sponsor

@openjdk openjdk bot closed this Dec 21, 2020
@openjdk openjdk bot added integrated Pull request has been integrated and removed sponsor Pull request is ready to be sponsored ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 21, 2020
@openjdk
Copy link

openjdk bot commented Dec 21, 2020

@dimitryc @kvergizova Since your change was applied there have been 5 commits pushed to the master branch:

  • 92aec52: 8245400: Upgrade to LittleCMS 2.11
  • 501e942: 8248532: Every time I change keyboard language at my MacBook, Java crashes
  • 05ac56a: 8239886: Minimal VM build fails after JDK-8237499
  • 85b7908: 8237499: JFR: Include stack trace in the ThreadStart event
  • 20251b7: 8247867: Upgrade to freetype 2.10.2

Your commit was automatically rebased without conflicts.

Pushed as commit ead24ad.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@kvergizova kvergizova deleted the backport-8252090 branch December 22, 2020 19:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport integrated Pull request has been integrated
2 participants