Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8257242: [macOS] Java app crashes while switching input methods #69

Closed
wants to merge 1 commit into from

Conversation

@omikhaltsova
Copy link
Contributor

@omikhaltsova omikhaltsova commented Dec 23, 2020

I'd like to backport JDK-8257242 to jdk13u for parity with jdk11u.
The original patch applied cleanly.
Tested with jtreg:test/jdk:jdk_awt. No regression in tests.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8257242: [macOS] Java app crashes while switching input methods

Download

$ git fetch https://git.openjdk.java.net/jdk13u-dev pull/69/head:pull/69
$ git checkout pull/69

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Dec 23, 2020

👋 Welcome back omikhaltcova! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 822ee47459d3a33ab3acd7f8798525967a20d237 8257242: [macOS] Java app crashes while switching input methods Dec 23, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Dec 23, 2020

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

@openjdk openjdk bot commented Dec 23, 2020

@omikhaltsova This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8257242: [macOS] Java app crashes while switching input methods

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 8 new commits pushed to the master branch:

  • 9db1121: 8255603: Memory/Performance regression after JDK-8210985
  • 164abd4: 8239000: handle ContendedPaddingWidth in vm_version_ppc
  • ead24ad: 8252090: JFR: StreamWriterHost::write_unbuffered() stucks in an infinite loop OpenJDK (build 13.0.1+9)
  • 92aec52: 8245400: Upgrade to LittleCMS 2.11
  • 501e942: 8248532: Every time I change keyboard language at my MacBook, Java crashes
  • 05ac56a: 8239886: Minimal VM build fails after JDK-8237499
  • 85b7908: 8237499: JFR: Include stack trace in the ThreadStart event
  • 20251b7: 8247867: Upgrade to freetype 2.10.2

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@mlbridge
Copy link

@mlbridge mlbridge bot commented Dec 23, 2020

Webrevs

@omikhaltsova
Copy link
Contributor Author

@omikhaltsova omikhaltsova commented Dec 23, 2020

/integrate

@openjdk openjdk bot added the sponsor label Dec 23, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Dec 23, 2020

@omikhaltsova
Your change (at version 8bd059d) is now ready to be sponsored by a Committer.

@yan-too
Copy link
Collaborator

@yan-too yan-too commented Dec 23, 2020

/sponsor

@openjdk
Copy link

@openjdk openjdk bot commented Dec 23, 2020

@yan-too @omikhaltsova Since your change was applied there have been 8 commits pushed to the master branch:

  • 9db1121: 8255603: Memory/Performance regression after JDK-8210985
  • 164abd4: 8239000: handle ContendedPaddingWidth in vm_version_ppc
  • ead24ad: 8252090: JFR: StreamWriterHost::write_unbuffered() stucks in an infinite loop OpenJDK (build 13.0.1+9)
  • 92aec52: 8245400: Upgrade to LittleCMS 2.11
  • 501e942: 8248532: Every time I change keyboard language at my MacBook, Java crashes
  • 05ac56a: 8239886: Minimal VM build fails after JDK-8237499
  • 85b7908: 8237499: JFR: Include stack trace in the ThreadStart event
  • 20251b7: 8247867: Upgrade to freetype 2.10.2

Your commit was automatically rebased without conflicts.

Pushed as commit ea904d8.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@omikhaltsova omikhaltsova deleted the omikhaltsova:backport-822ee474 branch Jan 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants