Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8234011: (zipfs) Memory leak in ZipFileSystem.releaseDeflater() #71

Closed
wants to merge 1 commit into from

Conversation

@kvergizova
Copy link
Contributor

@kvergizova kvergizova commented Dec 23, 2020

I'd like to backport 8234011 to 13u for parity with 11u.
The patch applies cleanly.
Tested with tier1 and jdk/nio/zipfs tests.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8234011: (zipfs) Memory leak in ZipFileSystem.releaseDeflater()

Download

$ git fetch https://git.openjdk.java.net/jdk13u-dev pull/71/head:pull/71
$ git checkout pull/71

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Dec 23, 2020

👋 Welcome back evergizova! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport a6fd1b4c4bad720a4fde0d51ace7f1cd56c8878c 8234011: (zipfs) Memory leak in ZipFileSystem.releaseDeflater() Dec 23, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Dec 23, 2020

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

@openjdk openjdk bot commented Dec 23, 2020

@kvergizova This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8234011: (zipfs) Memory leak in ZipFileSystem.releaseDeflater()

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • fba425d: 8210527: JShell: NullPointerException in jdk.jshell.Eval.translateExceptionStack
  • 5d25a8f: 8236859: WebSocket over authenticating proxy fails with NPE

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@mlbridge
Copy link

@mlbridge mlbridge bot commented Dec 23, 2020

Webrevs

@kvergizova
Copy link
Contributor Author

@kvergizova kvergizova commented Dec 23, 2020

/integrate

@openjdk openjdk bot added the sponsor label Dec 23, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Dec 23, 2020

@kvergizova
Your change (at version b3ce470) is now ready to be sponsored by a Committer.

@yan-too
Copy link
Collaborator

@yan-too yan-too commented Dec 24, 2020

/sponsor

@openjdk
Copy link

@openjdk openjdk bot commented Dec 24, 2020

@yan-too @kvergizova Since your change was applied there have been 2 commits pushed to the master branch:

  • fba425d: 8210527: JShell: NullPointerException in jdk.jshell.Eval.translateExceptionStack
  • 5d25a8f: 8236859: WebSocket over authenticating proxy fails with NPE

Your commit was automatically rebased without conflicts.

Pushed as commit 576cf03.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@kvergizova kvergizova deleted the backport-8234011 branch Jan 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants