Skip to content
This repository has been archived by the owner on Feb 2, 2023. It is now read-only.
/ jdk13u-dev Public archive

8173361: various crashes in JvmtiExport::post_compiled_method_load #73

Closed
wants to merge 1 commit into from

Conversation

kvergizova
Copy link
Contributor

@kvergizova kvergizova commented Jan 15, 2021

I'd like to backport 8173361 to 13u for parity with 11u.
The patch doesn't apply cleanly due to minor context differences in serviceThread.hpp and mutexLocker.cpp (JDK-8170299 and JDK-8231472 are not in 13u), reapplied manually.
Tested with tier1 and other jvmti tests.
Follow-up fix JDK-8235218 is planned to be backported as well.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8173361: various crashes in JvmtiExport::post_compiled_method_load

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk13u-dev pull/73/head:pull/73
$ git checkout pull/73

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 15, 2021

👋 Welcome back evergizova! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport b1d915ef80ebdf511dc2897b20ada78b3dc44241 8173361: various crashes in JvmtiExport::post_compiled_method_load Jan 15, 2021
@openjdk
Copy link

openjdk bot commented Jan 15, 2021

This backport pull request has now been updated with issue and summary from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Jan 15, 2021
@mlbridge
Copy link

mlbridge bot commented Jan 15, 2021

Webrevs

@openjdk
Copy link

openjdk bot commented Jan 18, 2021

@kvergizova This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8173361: various crashes in JvmtiExport::post_compiled_method_load

Don't post information that uses metadata from unloaded nmethods

Reviewed-by: yan

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 496c325: 8235846: Improve WindbgDebuggerLocal implementation

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@yan-too) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jan 18, 2021
@kvergizova
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Jan 18, 2021
@openjdk
Copy link

openjdk bot commented Jan 18, 2021

@kvergizova
Your change (at version 91734d1) is now ready to be sponsored by a Committer.

@yan-too
Copy link
Collaborator

yan-too commented Jan 18, 2021

/sponsor

@openjdk openjdk bot closed this Jan 18, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed sponsor Pull request is ready to be sponsored ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 18, 2021
@openjdk
Copy link

openjdk bot commented Jan 18, 2021

@yan-too @kvergizova Since your change was applied there has been 1 commit pushed to the master branch:

  • 496c325: 8235846: Improve WindbgDebuggerLocal implementation

Your commit was automatically rebased without conflicts.

Pushed as commit 79e77ae.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@kvergizova kvergizova deleted the backport-8173361 branch January 18, 2021 12:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants