Skip to content
This repository was archived by the owner on Feb 2, 2023. It is now read-only.

Conversation

@kvergizova
Copy link
Contributor

@kvergizova kvergizova commented Jan 18, 2021

I'd like to backport 8235218 to 13u as follow-up fix for JDK-8173361 that is already included to 13u.
The patch applies cleanly.
Minimal VM is built successfully after applying the patch.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

Download

$ git fetch https://git.openjdk.java.net/jdk13u-dev pull/77/head:pull/77
$ git checkout pull/77

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 18, 2021

👋 Welcome back evergizova! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport c10f731b11f314c97660df08c62f3c3d2f718f54 8235218: Minimal VM is broken after JDK-8173361 Jan 18, 2021
@openjdk
Copy link

openjdk bot commented Jan 18, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Jan 18, 2021

@kvergizova This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8235218: Minimal VM is broken after JDK-8173361

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 7943806: 8204994: SA might fail to attach to process with "Windbg Error: WaitForEvent failed"

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 18, 2021
@mlbridge
Copy link

mlbridge bot commented Jan 18, 2021

Webrevs

@kvergizova
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Jan 18, 2021
@openjdk
Copy link

openjdk bot commented Jan 18, 2021

@kvergizova
Your change (at version afd47c3) is now ready to be sponsored by a Committer.

@yan-too
Copy link
Collaborator

yan-too commented Jan 19, 2021

/sponsor

@openjdk openjdk bot closed this Jan 19, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed sponsor Pull request is ready to be sponsored ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 19, 2021
@openjdk
Copy link

openjdk bot commented Jan 19, 2021

@yan-too @kvergizova Since your change was applied there has been 1 commit pushed to the master branch:

  • 7943806: 8204994: SA might fail to attach to process with "Windbg Error: WaitForEvent failed"

Your commit was automatically rebased without conflicts.

Pushed as commit 9d0b4ff.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@kvergizova kvergizova deleted the backport-8235218 branch January 19, 2021 16:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

backport clean integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

2 participants