Skip to content
This repository was archived by the owner on Feb 2, 2023. It is now read-only.

Conversation

@kvergizova
Copy link
Contributor

@kvergizova kvergizova commented Jan 19, 2021

I'd like to backport 8248987 to 13u for parity with 11u.
The patch applies cleanly.
Changes are jaotc tool specific, tested with aot tests.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8248987: AOT's Linker.java seems to eagerly fail-fast on Windows.

Download

$ git fetch https://git.openjdk.java.net/jdk13u-dev pull/78/head:pull/78
$ git checkout pull/78

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 19, 2021

👋 Welcome back evergizova! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport e2353cc32484413584a87cb11a2853fc55999b8f 8248987: AOT's Linker.java seems to eagerly fail-fast on Windows Jan 19, 2021
@openjdk
Copy link

openjdk bot commented Jan 19, 2021

This backport pull request has now been updated with issue and summary from the original commit.

@openjdk openjdk bot added backport clean rfr Pull request is ready for review labels Jan 19, 2021
@mlbridge
Copy link

mlbridge bot commented Jan 19, 2021

Webrevs

@kvergizova kvergizova changed the title 8248987: AOT's Linker.java seems to eagerly fail-fast on Windows 8248987: AOT's Linker.java seems to eagerly fail-fast on Windows. Jan 20, 2021
@openjdk
Copy link

openjdk bot commented Jan 20, 2021

@kvergizova This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8248987: AOT's Linker.java seems to eagerly fail-fast on Windows.

Treat all problems in getVC141AndNewerLinker() as non-fatal. Print error messages with --verbose flag.

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • da062ac: Merge
  • 206f88d: 8247619: Improve Direct Buffering of Characters

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jan 20, 2021
@kvergizova
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Jan 20, 2021
@openjdk
Copy link

openjdk bot commented Jan 20, 2021

@kvergizova
Your change (at version 4d3b861) is now ready to be sponsored by a Committer.

@yan-too
Copy link
Collaborator

yan-too commented Jan 20, 2021

/sponsor

@openjdk openjdk bot closed this Jan 20, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed sponsor Pull request is ready to be sponsored ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 20, 2021
@openjdk
Copy link

openjdk bot commented Jan 20, 2021

@yan-too @kvergizova Since your change was applied there have been 2 commits pushed to the master branch:

  • da062ac: Merge
  • 206f88d: 8247619: Improve Direct Buffering of Characters

Your commit was automatically rebased without conflicts.

Pushed as commit bdeb890.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@kvergizova kvergizova deleted the backport-8248987 branch January 21, 2021 11:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

backport clean integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

2 participants