Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8257633: Missing -mmacosx-version-min=X flag when linking libjvm #79

Closed
wants to merge 1 commit into from

Conversation

@VladimirKempik
Copy link

@VladimirKempik VladimirKempik commented Jan 20, 2021

Please review this small changeset. Build-system only change.
Backport didn't apply cleanly due to context code differences, the patched code is the same.
After the fix applied, libjvm has both sha1 and sha256 signatures, which will allow it to run on older macos.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8257633: Missing -mmacosx-version-min=X flag when linking libjvm ⚠️ Issue is not open.

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk13u-dev pull/79/head:pull/79
$ git checkout pull/79

Backport-of: 51d325e613bfcf7f8016ba6d8b146afec6f0f85c
@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jan 20, 2021

👋 Welcome back vkempik! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Jan 20, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Jan 20, 2021

Webrevs

@VladimirKempik
Copy link
Author

@VladimirKempik VladimirKempik commented Jan 20, 2021

Original changeset - openjdk/jdk@51d325e

@openjdk
Copy link

@openjdk openjdk bot commented Jan 20, 2021

@VladimirKempik This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8257633: Missing -mmacosx-version-min=X flag when linking libjvm

Reviewed-by: yan

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • bdeb890: 8248987: AOT's Linker.java seems to eagerly fail-fast on Windows.

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Jan 20, 2021
@VladimirKempik
Copy link
Author

@VladimirKempik VladimirKempik commented Jan 20, 2021

/integrate

@openjdk openjdk bot closed this Jan 20, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Jan 20, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jan 20, 2021

@VladimirKempik Since your change was applied there has been 1 commit pushed to the master branch:

  • bdeb890: 8248987: AOT's Linker.java seems to eagerly fail-fast on Windows.

Your commit was automatically rebased without conflicts.

Pushed as commit 445bfe0.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@VladimirKempik VladimirKempik deleted the VladimirKempik:JDK-8257633 branch Jan 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants