Skip to content
This repository has been archived by the owner on Feb 2, 2023. It is now read-only.

8258396: SIGILL in jdk.jfr.internal.PlatformRecorder.rotateDisk() #80

Closed
wants to merge 1 commit into from

Conversation

kvergizova
Copy link
Contributor

@kvergizova kvergizova commented Jan 20, 2021

I'd like to backport 8258396, the issue is present there too.
The patch applies cleanly.
Tested with tier1 and jdk/jfr tests.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8258396: SIGILL in jdk.jfr.internal.PlatformRecorder.rotateDisk()

Download

$ git fetch https://git.openjdk.java.net/jdk13u-dev pull/80/head:pull/80
$ git checkout pull/80

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 20, 2021

👋 Welcome back evergizova! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport a06cea50a5ea04fb0399d7ea3f6a2a20d9b4d254 8258396: SIGILL in jdk.jfr.internal.PlatformRecorder.rotateDisk() Jan 20, 2021
@openjdk
Copy link

openjdk bot commented Jan 20, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Jan 20, 2021

@kvergizova This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8258396: SIGILL in jdk.jfr.internal.PlatformRecorder.rotateDisk()

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 4 new commits pushed to the master branch:

  • 445bfe0: 8257633: Missing -mmacosx-version-min=X flag when linking libjvm
  • bdeb890: 8248987: AOT's Linker.java seems to eagerly fail-fast on Windows.
  • da062ac: Merge
  • 206f88d: 8247619: Improve Direct Buffering of Characters

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 20, 2021
@mlbridge
Copy link

mlbridge bot commented Jan 20, 2021

Webrevs

@kvergizova
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Jan 20, 2021
@openjdk
Copy link

openjdk bot commented Jan 20, 2021

@kvergizova
Your change (at version 4c26916) is now ready to be sponsored by a Committer.

@yan-too
Copy link
Collaborator

yan-too commented Jan 20, 2021

/sponsor

@openjdk openjdk bot closed this Jan 20, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed sponsor Pull request is ready to be sponsored ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 20, 2021
@openjdk
Copy link

openjdk bot commented Jan 20, 2021

@yan-too @kvergizova Since your change was applied there have been 4 commits pushed to the master branch:

  • 445bfe0: 8257633: Missing -mmacosx-version-min=X flag when linking libjvm
  • bdeb890: 8248987: AOT's Linker.java seems to eagerly fail-fast on Windows.
  • da062ac: Merge
  • 206f88d: 8247619: Improve Direct Buffering of Characters

Your commit was automatically rebased without conflicts.

Pushed as commit 3e60cad.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@kvergizova kvergizova deleted the backport-8258396 branch January 21, 2021 11:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport clean integrated Pull request has been integrated
2 participants