Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8173658: JvmtiExport::post_class_unload() is broken for non-JavaThread initiators #81

Closed
wants to merge 1 commit into from

Conversation

@kvergizova
Copy link
Contributor

@kvergizova kvergizova commented Jan 21, 2021

I'd like to backport 8173658 to 13u for parity with 11u.
The patch applies cleanly, CSR for the fix is approved for 13u: JDK-8260003.
Tested with tier1 and jvmti tests.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8173658: JvmtiExport::post_class_unload() is broken for non-JavaThread initiators

Download

$ git fetch https://git.openjdk.java.net/jdk13u-dev pull/81/head:pull/81
$ git checkout pull/81

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jan 21, 2021

👋 Welcome back evergizova! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport d1d57d944632b6539ba1fcd654b4c7bd889ff604 8173658: JvmtiExport::post_class_unload() is broken for non-JavaThread initiators Jan 21, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jan 21, 2021

This backport pull request has now been updated with issue and summary from the original commit.

@openjdk
Copy link

@openjdk openjdk bot commented Jan 21, 2021

@kvergizova This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8173658: JvmtiExport::post_class_unload() is broken for non-JavaThread initiators

Call extension ClassUnload event as a deferred event from the ServiceThread and remove unsafe arguments

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@mlbridge
Copy link

@mlbridge mlbridge bot commented Jan 21, 2021

Webrevs

@kvergizova
Copy link
Contributor Author

@kvergizova kvergizova commented Jan 22, 2021

/integrate

@openjdk openjdk bot added the sponsor label Jan 22, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jan 22, 2021

@kvergizova
Your change (at version 5de97a3) is now ready to be sponsored by a Committer.

@yan-too
Copy link
Collaborator

@yan-too yan-too commented Jan 22, 2021

/sponsor

@openjdk
Copy link

@openjdk openjdk bot commented Jan 22, 2021

@yan-too @kvergizova Pushed as commit 51bca9f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@kvergizova kvergizova deleted the kvergizova:backport-8173658 branch Jan 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants