Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8255908: ExceptionInInitializerError due to UncheckedIOException while initializing cgroupv1 subsystem #82

Closed
wants to merge 1 commit into from

Conversation

@kvergizova
Copy link
Contributor

@kvergizova kvergizova commented Jan 22, 2021

I'd like to backport 8255908 to 13u for parity with 11u.
The patch doesn't apply cleanly since 13u doesn't have cgroups v2 support (JDK-8231111), so it reapplied manually to similar places in cgroupv1/Metrics.java and cgroupv1/SubSystem.java.
Tested with tier1 and container tests.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8255908: ExceptionInInitializerError due to UncheckedIOException while initializing cgroupv1 subsystem

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk13u-dev pull/82/head:pull/82
$ git checkout pull/82

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jan 22, 2021

👋 Welcome back evergizova! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 8d9cf48e813dee9567340720978392e04f736e65 8255908: ExceptionInInitializerError due to UncheckedIOException while initializing cgroupv1 subsystem Jan 22, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jan 22, 2021

This backport pull request has now been updated with issue from the original commit.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Jan 22, 2021

Webrevs

@openjdk
Copy link

@openjdk openjdk bot commented Jan 27, 2021

@kvergizova This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8255908: ExceptionInInitializerError due to UncheckedIOException while initializing cgroupv1 subsystem

Reviewed-by: yan

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 9 new commits pushed to the master branch:

  • b070099: 8244819: hsdis does not compile with binutils 2.34+
  • ad28e4f: 8226810: Failed to launch JVM because of NullPointerException occured on System.props
  • 614325c: 8251257: NMT: jcmd VM.native_memory scale=1 crashes target VM
  • 0bb1017: 8233027: OopMapSet::all_do does oms.next() twice during iteration
  • b5c0f98: 8222079: Don't use memset to initialize fields decode_env constructor in disassembler.cpp
  • be68489: 8232083: Minimal VM is broken after JDK-8231586
  • 40e0519: 8231586: enlarge encoding space for OopMapValue offsets
  • e0445f1: 8235584: UseProfiledLoopPredicate fails with assert(_phase->get_loop(c) == loop) failed: have to be in the same loop
  • 51bca9f: 8173658: JvmtiExport::post_class_unload() is broken for non-JavaThread initiators

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@yan-too) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready label Jan 27, 2021
@kvergizova
Copy link
Contributor Author

@kvergizova kvergizova commented Jan 27, 2021

/integrate

@openjdk openjdk bot added the sponsor label Jan 27, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jan 27, 2021

@kvergizova
Your change (at version f23c788) is now ready to be sponsored by a Committer.

@yan-too
Copy link
Collaborator

@yan-too yan-too commented Jan 27, 2021

/sponsor

@openjdk
Copy link

@openjdk openjdk bot commented Jan 27, 2021

@yan-too @kvergizova Since your change was applied there have been 9 commits pushed to the master branch:

  • b070099: 8244819: hsdis does not compile with binutils 2.34+
  • ad28e4f: 8226810: Failed to launch JVM because of NullPointerException occured on System.props
  • 614325c: 8251257: NMT: jcmd VM.native_memory scale=1 crashes target VM
  • 0bb1017: 8233027: OopMapSet::all_do does oms.next() twice during iteration
  • b5c0f98: 8222079: Don't use memset to initialize fields decode_env constructor in disassembler.cpp
  • be68489: 8232083: Minimal VM is broken after JDK-8231586
  • 40e0519: 8231586: enlarge encoding space for OopMapValue offsets
  • e0445f1: 8235584: UseProfiledLoopPredicate fails with assert(_phase->get_loop(c) == loop) failed: have to be in the same loop
  • 51bca9f: 8173658: JvmtiExport::post_class_unload() is broken for non-JavaThread initiators

Your commit was automatically rebased without conflicts.

Pushed as commit 9be352b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@kvergizova kvergizova deleted the backport-8255908 branch Jan 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants