Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8231586: enlarge encoding space for OopMapValue offsets #84

Closed
wants to merge 1 commit into from

Conversation

@omikhaltsova
Copy link
Contributor

@omikhaltsova omikhaltsova commented Jan 22, 2021

I'd like to backport JDK-8231586 to jdk13u for parity with jdk11u.
The original patch applied cleanly.
Tested with tier1. No regression in tests.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8231586: enlarge encoding space for OopMapValue offsets

Download

$ git fetch https://git.openjdk.java.net/jdk13u-dev pull/84/head:pull/84
$ git checkout pull/84

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jan 22, 2021

👋 Welcome back omikhaltcova! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 4a41f86a39de90f157adc296384ee7407f9f2a91 8231586: enlarge encoding space for OopMapValue offsets Jan 22, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jan 22, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

@openjdk openjdk bot commented Jan 22, 2021

@omikhaltsova This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8231586: enlarge encoding space for OopMapValue offsets

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • e0445f1: 8235584: UseProfiledLoopPredicate fails with assert(_phase->get_loop(c) == loop) failed: have to be in the same loop

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@omikhaltsova
Copy link
Contributor Author

@omikhaltsova omikhaltsova commented Jan 22, 2021

/integrate

@openjdk openjdk bot added the sponsor label Jan 22, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jan 22, 2021

@omikhaltsova
Your change (at version 00edbff) is now ready to be sponsored by a Committer.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Jan 22, 2021

Webrevs

@yan-too
Copy link
Collaborator

@yan-too yan-too commented Jan 22, 2021

/sponsor

@openjdk
Copy link

@openjdk openjdk bot commented Jan 22, 2021

@yan-too @omikhaltsova Since your change was applied there has been 1 commit pushed to the master branch:

  • e0445f1: 8235584: UseProfiledLoopPredicate fails with assert(_phase->get_loop(c) == loop) failed: have to be in the same loop

Your commit was automatically rebased without conflicts.

Pushed as commit 40e0519.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@omikhaltsova omikhaltsova deleted the omikhaltsova:backport-4a41f86a branch Mar 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants