Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8222079: Don't use memset to initialize fields decode_env constructor in disassembler.cpp #86

Closed
wants to merge 1 commit into from

Conversation

@yan-too
Copy link
Collaborator

@yan-too yan-too commented Jan 25, 2021

I'd like to port it to 13u, too. Applies totally clean.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8222079: Don't use memset to initialize fields decode_env constructor in disassembler.cpp

Download

$ git fetch https://git.openjdk.java.net/jdk13u-dev pull/86/head:pull/86
$ git checkout pull/86

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jan 25, 2021

👋 Welcome back yan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 9c2e15364c76f1189ed269c453b9ecbd559275b5 8222079: Don't use memset to initialize fields decode_env constructor in disassembler.cpp Jan 25, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jan 25, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

@openjdk openjdk bot commented Jan 25, 2021

@yan-too This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8222079: Don't use memset to initialize fields decode_env constructor in disassembler.cpp

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Jan 25, 2021

Webrevs

@yan-too
Copy link
Collaborator Author

@yan-too yan-too commented Jan 25, 2021

/integrate

@openjdk openjdk bot closed this Jan 25, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Jan 25, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jan 25, 2021

@yan-too Pushed as commit b5c0f98.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@yan-too yan-too deleted the yan-too:bp8222079 branch Jan 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant