Skip to content
This repository has been archived by the owner on Feb 2, 2023. It is now read-only.
/ jdk13u-dev Public archive

8212160: JVMTI agent crashes with "assert(_value != 0LL) failed: resolving NULL _value" #87

Closed
wants to merge 1 commit into from

Conversation

kvergizova
Copy link
Contributor

@kvergizova kvergizova commented Jan 25, 2021

I'd like to backport 8212160 to 13u for parity with 11u.
The patch doesn't apply cleanly due to minor context differences in nmethod.cpp and serviceThread.cpp (JDK-8235273 and JDK-8170299 are not in 13u), reapplied manually.
Tested with tier1 and other jvmti tests.
Follow-up fixes JDK-8235456 and JDK-8236124 are planned to be backported as well.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8212160: JVMTI agent crashes with "assert(_value != 0LL) failed: resolving NULL _value"

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk13u-dev pull/87/head:pull/87
$ git checkout pull/87

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 25, 2021

👋 Welcome back evergizova! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 8846a8043d1137ab1aeee3a4304d5fa02c9431ad 8212160: JVMTI agent crashes with "assert(_value != 0LL) failed: resolving NULL _value" Jan 25, 2021
@openjdk
Copy link

openjdk bot commented Jan 25, 2021

This backport pull request has now been updated with issue and summary from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Jan 25, 2021
@mlbridge
Copy link

mlbridge bot commented Jan 25, 2021

Webrevs

@openjdk
Copy link

openjdk bot commented Jan 28, 2021

@kvergizova This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8212160: JVMTI agent crashes with "assert(_value != 0LL) failed: resolving NULL _value"

Add local deferred event list to thread to post events outside CodeCache_lock.

Reviewed-by: yan

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 9 new commits pushed to the master branch:

  • 80f30ba: 8234687: change javap reporting on unknown attributes
  • 62f79b1: 7146776: deadlock between URLStreamHandler.getHostAddress and file.Handler.openconnection
  • 9be352b: 8255908: ExceptionInInitializerError due to UncheckedIOException while initializing cgroupv1 subsystem
  • b070099: 8244819: hsdis does not compile with binutils 2.34+
  • ad28e4f: 8226810: Failed to launch JVM because of NullPointerException occured on System.props
  • 614325c: 8251257: NMT: jcmd VM.native_memory scale=1 crashes target VM
  • 0bb1017: 8233027: OopMapSet::all_do does oms.next() twice during iteration
  • b5c0f98: 8222079: Don't use memset to initialize fields decode_env constructor in disassembler.cpp
  • be68489: 8232083: Minimal VM is broken after JDK-8231586

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@yan-too) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jan 28, 2021
@kvergizova
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Jan 29, 2021
@openjdk
Copy link

openjdk bot commented Jan 29, 2021

@kvergizova
Your change (at version ab01382) is now ready to be sponsored by a Committer.

@yan-too
Copy link
Collaborator

yan-too commented Jan 29, 2021

/sponsor

@openjdk openjdk bot closed this Jan 29, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed sponsor Pull request is ready to be sponsored ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 29, 2021
@openjdk
Copy link

openjdk bot commented Jan 29, 2021

@yan-too @kvergizova Since your change was applied there have been 9 commits pushed to the master branch:

  • 80f30ba: 8234687: change javap reporting on unknown attributes
  • 62f79b1: 7146776: deadlock between URLStreamHandler.getHostAddress and file.Handler.openconnection
  • 9be352b: 8255908: ExceptionInInitializerError due to UncheckedIOException while initializing cgroupv1 subsystem
  • b070099: 8244819: hsdis does not compile with binutils 2.34+
  • ad28e4f: 8226810: Failed to launch JVM because of NullPointerException occured on System.props
  • 614325c: 8251257: NMT: jcmd VM.native_memory scale=1 crashes target VM
  • 0bb1017: 8233027: OopMapSet::all_do does oms.next() twice during iteration
  • b5c0f98: 8222079: Don't use memset to initialize fields decode_env constructor in disassembler.cpp
  • be68489: 8232083: Minimal VM is broken after JDK-8231586

Your commit was automatically rebased without conflicts.

Pushed as commit 5c15783.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@kvergizova kvergizova deleted the backport-8212160 branch January 29, 2021 12:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants