Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8243290: Improve diagnostic messages for class verification and redefinition failures #95

Closed
wants to merge 1 commit into from

Conversation

kvergizova
Copy link
Contributor

@kvergizova kvergizova commented Jan 28, 2021

I'd like to backport 8243290 to 13u for parity with 11u.
The patch applies cleanly.
Tested with tier1.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8243290: Improve diagnostic messages for class verification and redefinition failures

Download

$ git fetch https://git.openjdk.java.net/jdk13u-dev pull/95/head:pull/95
$ git checkout pull/95

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 28, 2021

👋 Welcome back evergizova! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport ac4603144da1d763b97900747d0e83a59ad06ba7 8243290: Improve diagnostic messages for class verification and redefinition failures Jan 28, 2021
@openjdk
Copy link

openjdk bot commented Jan 28, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Jan 28, 2021

@kvergizova This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8243290: Improve diagnostic messages for class verification and redefinition failures

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

  • 80f30ba: 8234687: change javap reporting on unknown attributes
  • 62f79b1: 7146776: deadlock between URLStreamHandler.getHostAddress and file.Handler.openconnection
  • 9be352b: 8255908: ExceptionInInitializerError due to UncheckedIOException while initializing cgroupv1 subsystem

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready rfr labels Jan 28, 2021
@mlbridge
Copy link

mlbridge bot commented Jan 28, 2021

Webrevs

@kvergizova
Copy link
Contributor Author

kvergizova commented Jan 29, 2021

/integrate

@openjdk openjdk bot added the sponsor label Jan 29, 2021
@openjdk
Copy link

openjdk bot commented Jan 29, 2021

@kvergizova
Your change (at version 09aee67) is now ready to be sponsored by a Committer.

@yan-too
Copy link
Collaborator

yan-too commented Jan 29, 2021

/sponsor

@openjdk openjdk bot closed this Jan 29, 2021
@openjdk openjdk bot added integrated and removed sponsor ready rfr labels Jan 29, 2021
@openjdk
Copy link

openjdk bot commented Jan 29, 2021

@yan-too @kvergizova Since your change was applied there have been 5 commits pushed to the master branch:

  • fd622d3: 8256809: Annotation processing causes NPE during flow analysis
  • 5c15783: 8212160: JVMTI agent crashes with "assert(_value != 0LL) failed: resolving NULL _value"
  • 80f30ba: 8234687: change javap reporting on unknown attributes
  • 62f79b1: 7146776: deadlock between URLStreamHandler.getHostAddress and file.Handler.openconnection
  • 9be352b: 8255908: ExceptionInInitializerError due to UncheckedIOException while initializing cgroupv1 subsystem

Your commit was automatically rebased without conflicts.

Pushed as commit a27970f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@kvergizova kvergizova deleted the backport-8243290 branch Jan 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated
2 participants