Navigation Menu

Skip to content
This repository has been archived by the owner on Feb 2, 2023. It is now read-only.

Commit

Permalink
8269285: Crash/miscompile in CallGenerator::for_method_handle_inline …
Browse files Browse the repository at this point in the history
…after JDK-8191998

Backport-of: c16d1fc9810d5b2c112d35f3298513f86f84f66d
  • Loading branch information
Ilarion Nakonechnyy committed Sep 12, 2022
1 parent 008266b commit 5e52b38
Show file tree
Hide file tree
Showing 2 changed files with 63 additions and 2 deletions.
4 changes: 2 additions & 2 deletions src/hotspot/share/opto/callGenerator.cpp
Expand Up @@ -912,7 +912,7 @@ CallGenerator* CallGenerator::for_method_handle_inline(JVMState* jvms, ciMethod*
const TypeOopPtr* arg_type = arg->bottom_type()->isa_oopptr();
const Type* sig_type = TypeOopPtr::make_from_klass(signature->accessing_klass());
if (arg_type != NULL && !arg_type->higher_equal(sig_type)) {
const Type* recv_type = arg_type->join_speculative(sig_type); // keep speculative part
const Type* recv_type = arg_type->filter_speculative(sig_type); // keep speculative part
Node* cast_obj = gvn.transform(new CheckCastPPNode(kit.control(), arg, recv_type));
kit.set_argument(0, cast_obj);
}
Expand All @@ -925,7 +925,7 @@ CallGenerator* CallGenerator::for_method_handle_inline(JVMState* jvms, ciMethod*
const TypeOopPtr* arg_type = arg->bottom_type()->isa_oopptr();
const Type* sig_type = TypeOopPtr::make_from_klass(t->as_klass());
if (arg_type != NULL && !arg_type->higher_equal(sig_type)) {
const Type* narrowed_arg_type = arg_type->join_speculative(sig_type); // keep speculative part
const Type* narrowed_arg_type = arg_type->filter_speculative(sig_type); // keep speculative part
Node* cast_obj = gvn.transform(new CheckCastPPNode(kit.control(), arg, narrowed_arg_type));
kit.set_argument(receiver_skip + j, cast_obj);
}
Expand Down
61 changes: 61 additions & 0 deletions test/hotspot/jtreg/compiler/types/TestMethodHandleSpeculation.java
@@ -0,0 +1,61 @@
/*
* Copyright (c) 2021, Red Hat, Inc.. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
* under the terms of the GNU General Public License version 2 only, as
* published by the Free Software Foundation.
*
* This code is distributed in the hope that it will be useful, but WITHOUT
* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
* FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
* version 2 for more details (a copy is included in the LICENSE file that
* accompanied this code).
*
* You should have received a copy of the GNU General Public License version
* 2 along with this work; if not, write to the Free Software Foundation,
* Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
*
* Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
* or visit www.oracle.com if you need additional information or have any
* questions.
*/

/*
* @test
* @bug 8269285
* @summary Crash/miscompile in CallGenerator::for_method_handle_inline after JDK-8191998
* @requires vm.compMode == "Xmixed" & vm.flavor == "server"
*
* @run main/othervm
* -Xcomp -XX:CompileCommand=quiet -XX:CompileCommand=compileonly,compiler.types.TestMethodHandleSpeculation::main
* compiler.types.TestMethodHandleSpeculation
*/

package compiler.types;

import java.io.Serializable;
import java.util.Arrays;
import java.util.function.Supplier;

public class TestMethodHandleSpeculation {

public static void main(String... args) {
byte[] serObj = {1};
MyClass<byte[]> obj = new MyClass<>();
for (int i = 0; i < 100_000; i++) {
boolean test = obj.test(serObj);
if (test) {
throw new IllegalStateException("Cannot be null");
}
}
}

static class MyClass<V extends Serializable> {
boolean test(V obj) {
Supplier<Boolean> supp = () -> (obj == null);
return supp.get();
}
}

}

1 comment on commit 5e52b38

@openjdk-notifier
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sign in to comment.