Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8260704: ParallelGC: oldgen expansion needs release-store for _end #100

Closed
wants to merge 1 commit into from

Conversation

omikhaltsova
Copy link

@omikhaltsova omikhaltsova commented Sep 15, 2021

I'd like to backport JDK-8260704 to jdk15u for parity with jdk11u.
The original patch applied manually due to the slight context changes.
All regular tests passed.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8260704: ParallelGC: oldgen expansion needs release-store for _end

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk15u-dev pull/100/head:pull/100
$ git checkout pull/100

Update a local copy of the PR:
$ git checkout pull/100
$ git pull https://git.openjdk.java.net/jdk15u-dev pull/100/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 100

View PR using the GUI difftool:
$ git pr show -t 100

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk15u-dev/pull/100.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Sep 15, 2021

👋 Welcome back omikhaltcova! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport afd5eefdae388a53a0d6bffc2cf94b878ac1881e 8260704: ParallelGC: oldgen expansion needs release-store for _end Sep 15, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Sep 15, 2021

This backport pull request has now been updated with issue and summary from the original commit.

@openjdk openjdk bot added backport rfr labels Sep 15, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Sep 15, 2021

Webrevs

@openjdk
Copy link

@openjdk openjdk bot commented Sep 16, 2021

@omikhaltsova This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8260704: ParallelGC: oldgen expansion needs release-store for _end

Move JDK-8257999 barrier to correct location.

Reviewed-by: yan

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@yan-too) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready label Sep 16, 2021
@omikhaltsova
Copy link
Author

@omikhaltsova omikhaltsova commented Sep 16, 2021

/integrate

@openjdk openjdk bot added the sponsor label Sep 16, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Sep 16, 2021

@omikhaltsova
Your change (at version 98e7104) is now ready to be sponsored by a Committer.

@yan-too
Copy link
Collaborator

@yan-too yan-too commented Sep 16, 2021

/sponsor

@openjdk
Copy link

@openjdk openjdk bot commented Sep 16, 2021

Going to push as commit d5d9b45.

@openjdk openjdk bot closed this Sep 16, 2021
@openjdk openjdk bot added integrated and removed ready rfr sponsor labels Sep 16, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Sep 16, 2021

@yan-too @omikhaltsova Pushed as commit d5d9b45.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated
2 participants