Skip to content
This repository was archived by the owner on Feb 2, 2023. It is now read-only.
/ jdk15u-dev Public archive

8273358: macOS Monterey does not have the font Times needed by Serif #107

Closed
wants to merge 1 commit into from

Conversation

omikhaltsova
Copy link

@omikhaltsova omikhaltsova commented Sep 29, 2021

I'd like to backport JDK-8273358 to jdk15u for parity with jdk11u.
The original patch applies cleanly but 2 logging methods were replaced as in jdk11u because they are not available in jdk15u as well (the replaced methods were added with JDK-8248802 to jdk16u only). The patch is absolutely identical to that one applied to jdk11u.
Tested with the test added in this patch.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8273358: macOS Monterey does not have the font Times needed by Serif

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk15u-dev pull/107/head:pull/107
$ git checkout pull/107

Update a local copy of the PR:
$ git checkout pull/107
$ git pull https://git.openjdk.java.net/jdk15u-dev pull/107/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 107

View PR using the GUI difftool:
$ git pr show -t 107

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk15u-dev/pull/107.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 29, 2021

👋 Welcome back omikhaltcova! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport efe3ed1e705a6f3785761e64f7187de809daa731 8273358: macOS Monterey does not have the font Times needed by Serif Sep 29, 2021
@openjdk
Copy link

openjdk bot commented Sep 29, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Sep 29, 2021
@mlbridge
Copy link

mlbridge bot commented Sep 29, 2021

Webrevs

@omikhaltsova
Copy link
Author

/integrate

@openjdk
Copy link

openjdk bot commented Sep 30, 2021

@omikhaltsova This PR has not yet been marked as ready for integration.

@openjdk
Copy link

openjdk bot commented Sep 30, 2021

@omikhaltsova This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8273358: macOS Monterey does not have the font Times needed by Serif

Reviewed-by: yan

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@yan-too) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Sep 30, 2021
@omikhaltsova
Copy link
Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Sep 30, 2021
@openjdk
Copy link

openjdk bot commented Sep 30, 2021

@omikhaltsova
Your change (at version cbabcae) is now ready to be sponsored by a Committer.

@yan-too
Copy link
Collaborator

yan-too commented Sep 30, 2021

/sponsor

@openjdk
Copy link

openjdk bot commented Sep 30, 2021

Going to push as commit 9648f1a.

@openjdk openjdk bot closed this Sep 30, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Sep 30, 2021
@openjdk
Copy link

openjdk bot commented Sep 30, 2021

@yan-too @omikhaltsova Pushed as commit 9648f1a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants