Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8264752: SIGFPE crash with option FlightRecorderOptions:threadbuffersize=30M #108

Closed
wants to merge 1 commit into from

Conversation

@kvergizova
Copy link

@kvergizova kvergizova commented Oct 1, 2021

I'd like to backport this fix to 15u for parity with 11u.
The patch applies almost cleanly except for copyright years. Additionally the added test TestBadOptionValues.java was modified to pass successfully.
Tested with jdk/jfr tests, new test fails without the patch, passes with it.
Follow-up fix JDK-8266206 is planned to be backported as well.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8264752: SIGFPE crash with option FlightRecorderOptions:threadbuffersize=30M

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk15u-dev pull/108/head:pull/108
$ git checkout pull/108

Update a local copy of the PR:
$ git checkout pull/108
$ git pull https://git.openjdk.java.net/jdk15u-dev pull/108/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 108

View PR using the GUI difftool:
$ git pr show -t 108

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk15u-dev/pull/108.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Oct 1, 2021

👋 Welcome back evergizova! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

@openjdk openjdk bot changed the title Backport 377b346189c7cff9c8d535c3a6980f86669a95a0 8264752: SIGFPE crash with option FlightRecorderOptions:threadbuffersize=30M Oct 1, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Oct 1, 2021

This backport pull request has now been updated with issue from the original commit.

Loading

@mlbridge
Copy link

@mlbridge mlbridge bot commented Oct 1, 2021

Webrevs

Loading

yan-too
yan-too approved these changes Oct 1, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Oct 1, 2021

@kvergizova This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8264752: SIGFPE crash with option FlightRecorderOptions:threadbuffersize=30M

Reviewed-by: yan

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • 9648f1a: 8273358: macOS Monterey does not have the font Times needed by Serif
  • da8aac4: 8274056: JavaAccessibilityUtilities leaks JNI objects

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

Loading

@openjdk openjdk bot added the ready label Oct 1, 2021
@kvergizova
Copy link
Author

@kvergizova kvergizova commented Oct 1, 2021

/integrate

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Oct 1, 2021

Going to push as commit 4bbb64e.
Since your change was applied there have been 2 commits pushed to the master branch:

  • 9648f1a: 8273358: macOS Monterey does not have the font Times needed by Serif
  • da8aac4: 8274056: JavaAccessibilityUtilities leaks JNI objects

Your commit was automatically rebased without conflicts.

Loading

@openjdk openjdk bot closed this Oct 1, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Oct 1, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Oct 1, 2021

@kvergizova Pushed as commit 4bbb64e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants