Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8259651: [macOS] Replace JNF_COCOA_ENTER/EXIT macros #11

Conversation

@VladimirKempik
Copy link
Contributor

@VladimirKempik VladimirKempik commented Apr 2, 2021

Part 5/8 of JNF removal patches, applies almost cleanly, only slight context code difference in one place


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8259651: [macOS] Replace JNF_COCOA_ENTER/EXIT macros

Reviewers

  • serb - Reviewer ⚠️ Added manually

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk15u-dev pull/11/head:pull/11
$ git checkout pull/11

Update a local copy of the PR:
$ git checkout pull/11
$ git pull https://git.openjdk.java.net/jdk15u-dev pull/11/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 11

View PR using the GUI difftool:
$ git pr show -t 11

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk15u-dev/pull/11.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Apr 2, 2021

👋 Welcome back vkempik! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 5855d52a2a670a49b7a968fd58404b5d1836a8e1 8259651: [macOS] Replace JNF_COCOA_ENTER/EXIT macros Apr 2, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Apr 2, 2021

This backport pull request has now been updated with issue from the original commit.

@VladimirKempik
Copy link
Contributor Author

@VladimirKempik VladimirKempik commented Apr 2, 2021

/clean

@openjdk
Copy link

@openjdk openjdk bot commented Apr 2, 2021

@VladimirKempik This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8259651: [macOS] Replace JNF_COCOA_ENTER/EXIT macros

Reviewed-by: serb
Backport-of: 5855d52a2a670a49b7a968fd58404b5d1836a8e1

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk
Copy link

@openjdk openjdk bot commented Apr 2, 2021

@VladimirKempik @VladimirKempik this backport pull request is already marked as clean

@mlbridge
Copy link

@mlbridge mlbridge bot commented Apr 2, 2021

Webrevs

@VladimirKempik
Copy link
Contributor Author

@VladimirKempik VladimirKempik commented Apr 2, 2021

/reviewer credit serb

@openjdk
Copy link

@openjdk openjdk bot commented Apr 2, 2021

@VladimirKempik
Reviewer serb successfully credited.

@VladimirKempik
Copy link
Contributor Author

@VladimirKempik VladimirKempik commented Apr 2, 2021

/integrate

@openjdk openjdk bot closed this Apr 2, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Apr 2, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Apr 2, 2021

@VladimirKempik Pushed as commit efd22bb.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@VladimirKempik VladimirKempik deleted the VladimirKempik:backport-5855d52a2a670a49b7a968fd58404b5d1836a8e1 branch Apr 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant