Skip to content
This repository has been archived by the owner on Feb 2, 2023. It is now read-only.

8270533: AArch64: size_fits_all_mem_uses should return false if its output is a CAS #128

Closed
wants to merge 1 commit into from

Conversation

apavlyutkin
Copy link
Contributor

@apavlyutkin apavlyutkin commented Nov 1, 2021

I'd like to backport JDK-8190753 to jdk15u.

The fix prevents using a result of Shift-n-Add operation as an input for CAS operation that takes only register operands for Aarch64

The original patch applied cleanly

Testing: original patch does not have verification tests. Regression: arm64 / 20.04 LTS / hotspot_all


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8270533: AArch64: size_fits_all_mem_uses should return false if its output is a CAS

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk15u-dev pull/128/head:pull/128
$ git checkout pull/128

Update a local copy of the PR:
$ git checkout pull/128
$ git pull https://git.openjdk.java.net/jdk15u-dev pull/128/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 128

View PR using the GUI difftool:
$ git pr show -t 128

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk15u-dev/pull/128.diff

@apavlyutkin
Copy link
Contributor Author

/covered

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 1, 2021

👋 Welcome back apavlyutkin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 1, 2021

You are already a known contributor!

@openjdk openjdk bot changed the title Backport 6750c34c92b5f28bba4a88ac798b800fce380d32 8270533: AArch64: size_fits_all_mem_uses should return false if its output is a CAS Nov 1, 2021
@openjdk
Copy link

openjdk bot commented Nov 1, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Nov 1, 2021

@apavlyutkin This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8270533: AArch64: size_fits_all_mem_uses should return false if its output is a CAS

Reviewed-by: aph

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 41 new commits pushed to the master branch:

  • 76109b5: 8275766: (tz) Update Timezone Data to 2021e
  • 48f53ef: 8266949: Check possibility to disable OperationTimedOut on Unix
  • d17731b: 8260589: Crash in JfrTraceIdLoadBarrier::load(_jclass*)
  • 87f3b0e: 8196100: javax/swing/text/JTextComponent/5074573/bug5074573.java fails
  • 8716863: 8273790: Potential cyclic dependencies between Gregorian and CalendarSystem
  • b056995: 8253421: Initialize JFR trace-IDs with zero
  • 8719fc4: 8270893: IndexOutOfBoundsException while reading large TIFF file
  • ca60952: 8274779: HttpURLConnection: HttpClient and HttpsClient incorrectly check request method when set to POST
  • d38d207: 8190753: (zipfs): Accessing a large entry (> 2^31 bytes) leads to a negative initial size for ByteArrayOutputStream
  • 0e6a183: 8274407: (tz) Update Timezone Data to 2021c
  • ... and 31 more: https://git.openjdk.java.net/jdk15u-dev/compare/ade1c31fe3e3e2e26f6b987d506456e3101f7231...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@theRealAph) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 1, 2021
@mlbridge
Copy link

mlbridge bot commented Nov 1, 2021

Webrevs

@apavlyutkin
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Nov 9, 2021
@openjdk
Copy link

openjdk bot commented Nov 9, 2021

@apavlyutkin
Your change (at version 72a3311) is now ready to be sponsored by a Committer.

@yan-too
Copy link
Collaborator

yan-too commented Nov 9, 2021

/sponsor

@openjdk
Copy link

openjdk bot commented Nov 9, 2021

Going to push as commit c234390.
Since your change was applied there have been 42 commits pushed to the master branch:

  • 4753c72: 8273826: Correct Manifest file name and NPE checks
  • 76109b5: 8275766: (tz) Update Timezone Data to 2021e
  • 48f53ef: 8266949: Check possibility to disable OperationTimedOut on Unix
  • d17731b: 8260589: Crash in JfrTraceIdLoadBarrier::load(_jclass*)
  • 87f3b0e: 8196100: javax/swing/text/JTextComponent/5074573/bug5074573.java fails
  • 8716863: 8273790: Potential cyclic dependencies between Gregorian and CalendarSystem
  • b056995: 8253421: Initialize JFR trace-IDs with zero
  • 8719fc4: 8270893: IndexOutOfBoundsException while reading large TIFF file
  • ca60952: 8274779: HttpURLConnection: HttpClient and HttpsClient incorrectly check request method when set to POST
  • d38d207: 8190753: (zipfs): Accessing a large entry (> 2^31 bytes) leads to a negative initial size for ByteArrayOutputStream
  • ... and 32 more: https://git.openjdk.java.net/jdk15u-dev/compare/ade1c31fe3e3e2e26f6b987d506456e3101f7231...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Nov 9, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Nov 9, 2021
@openjdk
Copy link

openjdk bot commented Nov 9, 2021

@yan-too @apavlyutkin Pushed as commit c234390.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport clean integrated Pull request has been integrated
3 participants