Skip to content
This repository was archived by the owner on Feb 2, 2023. It is now read-only.
/ jdk15u-dev Public archive

8274293: Build failure on macOS with Xcode 13.0 as vfork is deprecated #135

Closed
wants to merge 1 commit into from

Conversation

omikhaltsova
Copy link

@omikhaltsova omikhaltsova commented Nov 16, 2021

I'd like to backport JDK-8274293 to jdk15u for parity with jdk11u.
The same issue is observed on macOS Monterey 12.0.1 while compiling with Xcode 13.0 (--disable-warnings-as-errors is used because it's not the only issue at the moment):

/Users/olgamikhaltsova/projects/jdk15u-dev-fork/src/java.base/unix/native/libjava/ProcessImpl_md.c:458:17: warning: 'vfork' is deprecated: Use posix_spawn or fork [-Wdeprecated-declarations]
    resultPid = vfork();
                ^
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX12.0.sdk/usr/include/unistd.h:604:1: note: 'vfork' has been explicitly marked deprecated here
__deprecated_msg("Use posix_spawn or fork")
^
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX12.0.sdk/usr/include/sys/cdefs.h:208:48: note: expanded from macro '__deprecated_msg'
        #define __deprecated_msg(_msg) __attribute__((__deprecated__(_msg)))
                                                      ^
1 warning generated.

The original patch applied cleanly but partially only to ProcessImpl_md.c because os_posix.cpp doesn't need any fixes due to JDK-8262955 is not included to jdk15u.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8274293: Build failure on macOS with Xcode 13.0 as vfork is deprecated

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk15u-dev pull/135/head:pull/135
$ git checkout pull/135

Update a local copy of the PR:
$ git checkout pull/135
$ git pull https://git.openjdk.java.net/jdk15u-dev pull/135/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 135

View PR using the GUI difftool:
$ git pr show -t 135

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk15u-dev/pull/135.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 16, 2021

👋 Welcome back omikhaltcova! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 252aaa9249d8979366b37d59487b5b039d923e35 8274293: Build failure on macOS with Xcode 13.0 as vfork is deprecated Nov 16, 2021
@openjdk
Copy link

openjdk bot commented Nov 16, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added the backport label Nov 16, 2021
@openjdk
Copy link

openjdk bot commented Nov 17, 2021

@omikhaltsova This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8274293: Build failure on macOS with Xcode 13.0 as vfork is deprecated

Reviewed-by: yan

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • dbb6ebf: 8276536: Update TimeZoneNames files to follow the changes made by JDK-8275766

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@yan-too) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Nov 17, 2021
@omikhaltsova omikhaltsova marked this pull request as ready for review November 17, 2021 16:15
@omikhaltsova
Copy link
Author

/integrate

@openjdk openjdk bot added rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Nov 17, 2021
@openjdk
Copy link

openjdk bot commented Nov 17, 2021

@omikhaltsova
Your change (at version 74358f2) is now ready to be sponsored by a Committer.

@mlbridge
Copy link

mlbridge bot commented Nov 17, 2021

Webrevs

@yan-too
Copy link
Collaborator

yan-too commented Nov 18, 2021

/sponsor

@openjdk
Copy link

openjdk bot commented Nov 18, 2021

Going to push as commit f76b4e8.
Since your change was applied there has been 1 commit pushed to the master branch:

  • dbb6ebf: 8276536: Update TimeZoneNames files to follow the changes made by JDK-8275766

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Nov 18, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Nov 18, 2021
@openjdk
Copy link

openjdk bot commented Nov 18, 2021

@yan-too @omikhaltsova Pushed as commit f76b4e8.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants