Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8249821: Separate libharfbuzz from libfontmanager #138

Conversation

dimitryc
Copy link
Collaborator

@dimitryc dimitryc commented Nov 22, 2021

JDK-8249821: Separate libharfbuzz from libfontmanager

Clean backport. Will create separate PR for JDK-8250605: Linux x86_32 builds fail after JDK-8249821


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8249821: Separate libharfbuzz from libfontmanager

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk15u-dev pull/138/head:pull/138
$ git checkout pull/138

Update a local copy of the PR:
$ git checkout pull/138
$ git pull https://git.openjdk.java.net/jdk15u-dev pull/138/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 138

View PR using the GUI difftool:
$ git pr show -t 138

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk15u-dev/pull/138.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Nov 22, 2021

👋 Welcome back dcherepanov! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport b1ff2bd00a6a289be29158e0acd134151b468d41 8249821: Separate libharfbuzz from libfontmanager Nov 22, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Nov 22, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

@openjdk openjdk bot commented Nov 22, 2021

@dimitryc This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8249821: Separate libharfbuzz from libfontmanager

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready rfr labels Nov 22, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Nov 22, 2021

Webrevs

@dimitryc
Copy link
Collaborator Author

@dimitryc dimitryc commented Nov 22, 2021

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Nov 22, 2021

Going to push as commit 5bc3e18.

@openjdk openjdk bot closed this Nov 22, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Nov 22, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Nov 22, 2021

@dimitryc Pushed as commit 5bc3e18.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@dimitryc dimitryc deleted the backport-8249821-separate-libharfbuzz branch Nov 22, 2021
@jerboaa
Copy link
Contributor

@jerboaa jerboaa commented Nov 23, 2021

@dimitryc I suggest to also backport https://bugs.openjdk.java.net/browse/JDK-8255790 to JDK 15 now so as to not introduce regressions. It's basically a revert of this backport. See for example https://bugs.openjdk.java.net/browse/JDK-8272149 for a rather simple test which crashes the JVM.

@dimitryc
Copy link
Collaborator Author

@dimitryc dimitryc commented Nov 23, 2021

@jerboaa Thanks! Will backport https://bugs.openjdk.java.net/browse/JDK-8255790 too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated
2 participants