Skip to content
This repository has been archived by the owner on Feb 2, 2023. It is now read-only.

8273026: Slow LoginContext.login() on multi threading application #141

Closed
wants to merge 1 commit into from

Conversation

Larry-N
Copy link
Contributor

@Larry-N Larry-N commented Nov 22, 2021

Backport the fix 8273026. Applied with conflicts, tested by tier2.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8273026: Slow LoginContext.login() on multi threading application

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk15u-dev pull/141/head:pull/141
$ git checkout pull/141

Update a local copy of the PR:
$ git checkout pull/141
$ git pull https://git.openjdk.java.net/jdk15u-dev pull/141/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 141

View PR using the GUI difftool:
$ git pr show -t 141

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk15u-dev/pull/141.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 22, 2021

👋 Welcome back Larry-N! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport c0cda1db4fe74b86faa12136336bdf98c96758d2 8273026: Slow LoginContext.login() on multi threading application Nov 22, 2021
@openjdk
Copy link

openjdk bot commented Nov 22, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Nov 22, 2021
@mlbridge
Copy link

mlbridge bot commented Nov 22, 2021

Webrevs

@openjdk
Copy link

openjdk bot commented Nov 23, 2021

@Larry-N This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8273026: Slow LoginContext.login() on multi threading application

Reviewed-by: yan

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

  • c361e15: 8250894: Provide a configure option to build and run against the platform libharfbuzz
  • e6d8cfc: 8250605: Linux x86_32 builds fail after JDK-8249821
  • 5bc3e18: 8249821: Separate libharfbuzz from libfontmanager

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@yan-too) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Nov 23, 2021
@Larry-N
Copy link
Contributor Author

Larry-N commented Nov 23, 2021

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Nov 23, 2021
@openjdk
Copy link

openjdk bot commented Nov 23, 2021

@Larry-N
Your change (at version 7943423) is now ready to be sponsored by a Committer.

@yan-too
Copy link
Collaborator

yan-too commented Nov 23, 2021

/sponsor

@openjdk
Copy link

openjdk bot commented Nov 23, 2021

Going to push as commit 408901d.
Since your change was applied there have been 3 commits pushed to the master branch:

  • c361e15: 8250894: Provide a configure option to build and run against the platform libharfbuzz
  • e6d8cfc: 8250605: Linux x86_32 builds fail after JDK-8249821
  • 5bc3e18: 8249821: Separate libharfbuzz from libfontmanager

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Nov 23, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Nov 23, 2021
@openjdk
Copy link

openjdk bot commented Nov 23, 2021

@yan-too @Larry-N Pushed as commit 408901d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@Larry-N Larry-N deleted the backport-c0cda1db branch August 12, 2022 17:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport integrated Pull request has been integrated
2 participants