Skip to content
This repository was archived by the owner on Feb 2, 2023. It is now read-only.

8255790: GTKL&F: Java 16 crashes on initialising GTKL&F on Manjaro Linux #143

Closed

Conversation

dimitryc
Copy link
Collaborator

@dimitryc dimitryc commented Nov 24, 2021

Follow up for JDK-8249821: Separate libharfbuzz from libfontmanager

The original patch doesn't apply cleanly. Applied it manually without implicit including parts of other patches for [1]/[2]/[3] that aren't currently in jdk15u. Also, [4] was included as a part of this patch. So the backport for jdk15u should be very similar to the backport for jdk11u.

Tested with the reproducer for JDK-8272149 (fails without the fix, passes with the fix).

[1] JDK-8258484: AIX build fails in Harfbuzz with XLC 16.01.0000.0006
[2] JDK-8074844: Resolve disabled warnings for libfontmanager
[3] JDK-8247872: Upgrade HarfBuzz to the latest 2.7.2
[4] JDK-8272332: --with-harfbuzz=system doesn't add -lharfbuzz after JDK-8255790


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issues

  • JDK-8255790: GTKL&F: Java 16 crashes on initialising GTKL&F on Manjaro Linux
  • JDK-8272332: --with-harfbuzz=system doesn't add -lharfbuzz after JDK-8255790

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk15u-dev pull/143/head:pull/143
$ git checkout pull/143

Update a local copy of the PR:
$ git checkout pull/143
$ git pull https://git.openjdk.java.net/jdk15u-dev pull/143/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 143

View PR using the GUI difftool:
$ git pr show -t 143

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk15u-dev/pull/143.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 24, 2021

👋 Welcome back dcherepanov! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 05fe06a6bafc089c6466ccbdea335e5dbfdaf335 8255790: GTKL&F: Java 16 crashes on initialising GTKL&F on Manjaro Linux Nov 24, 2021
@openjdk
Copy link

openjdk bot commented Nov 24, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Nov 24, 2021
@mlbridge
Copy link

mlbridge bot commented Nov 24, 2021

Webrevs

@dimitryc
Copy link
Collaborator Author

/issue add JDK-8272332

@openjdk
Copy link

openjdk bot commented Nov 24, 2021

@dimitryc This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8255790: GTKL&F: Java 16 crashes on initialising GTKL&F on Manjaro Linux
8272332: --with-harfbuzz=system doesn't add -lharfbuzz after JDK-8255790

Reviewed-by: yan

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

  • 83aec21: 8248865: Document JNDI/LDAP timeout properties
  • de7f192: 8262316: Reducing locks in RSA Blinding
  • 408901d: 8273026: Slow LoginContext.login() on multi threading application

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Nov 24, 2021
@openjdk
Copy link

openjdk bot commented Nov 24, 2021

@dimitryc
Adding additional issue to issue list: 8272332: --with-harfbuzz=system doesn't add -lharfbuzz after JDK-8255790.

@dimitryc
Copy link
Collaborator Author

/integrate

@openjdk
Copy link

openjdk bot commented Nov 24, 2021

Going to push as commit 3adb4ce.
Since your change was applied there have been 3 commits pushed to the master branch:

  • 83aec21: 8248865: Document JNDI/LDAP timeout properties
  • de7f192: 8262316: Reducing locks in RSA Blinding
  • 408901d: 8273026: Slow LoginContext.login() on multi threading application

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Nov 24, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 24, 2021
@openjdk
Copy link

openjdk bot commented Nov 24, 2021

@dimitryc Pushed as commit 3adb4ce.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@dimitryc dimitryc deleted the backport-8255790-manjaro-problem branch November 24, 2021 13:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants