Skip to content
This repository was archived by the owner on Feb 2, 2023. It is now read-only.
/ jdk15u-dev Public archive

8248865: Document JNDI/LDAP timeout properties #144

Closed
wants to merge 1 commit into from

Conversation

alexeybakhtin
Copy link
Contributor

@alexeybakhtin alexeybakhtin commented Nov 24, 2021

Clean backport.
Required for JDK-8245527


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk15u-dev pull/144/head:pull/144
$ git checkout pull/144

Update a local copy of the PR:
$ git checkout pull/144
$ git pull https://git.openjdk.java.net/jdk15u-dev pull/144/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 144

View PR using the GUI difftool:
$ git pr show -t 144

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk15u-dev/pull/144.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 24, 2021

👋 Welcome back abakhtin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport d308558d4fb98fc85b6574a9de229b255fc7ee7c 8248865: Document JNDI/LDAP timeout properties Nov 24, 2021
@openjdk
Copy link

openjdk bot commented Nov 24, 2021

This backport pull request has now been updated with issue and summary from the original commit.

@openjdk
Copy link

openjdk bot commented Nov 24, 2021

@alexeybakhtin This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8248865: Document JNDI/LDAP timeout properties

Documentation added in the module-info of java.naming

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 24, 2021
@mlbridge
Copy link

mlbridge bot commented Nov 24, 2021

Webrevs

@alexeybakhtin
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Nov 24, 2021
@openjdk
Copy link

openjdk bot commented Nov 24, 2021

@alexeybakhtin
Your change (at version 9ddb9f7) is now ready to be sponsored by a Committer.

@yan-too
Copy link
Collaborator

yan-too commented Nov 24, 2021

/sponsor

@openjdk
Copy link

openjdk bot commented Nov 24, 2021

Going to push as commit 83aec21.

@openjdk openjdk bot closed this Nov 24, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Nov 24, 2021
@openjdk
Copy link

openjdk bot commented Nov 24, 2021

@yan-too @alexeybakhtin Pushed as commit 83aec21.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants