Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8261231: Windows IME was disabled after DnD operation #15

Closed
wants to merge 1 commit into from

Conversation

@yan-too
Copy link
Collaborator

@yan-too yan-too commented Apr 5, 2021

bug reproduced in the current state jdk15u-dev (with JDK-8252470) and fix worked there as expected.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8261231: Windows IME was disabled after DnD operation

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk15u-dev pull/15/head:pull/15
$ git checkout pull/15

Update a local copy of the PR:
$ git checkout pull/15
$ git pull https://git.openjdk.java.net/jdk15u-dev pull/15/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 15

View PR using the GUI difftool:
$ git pr show -t 15

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk15u-dev/pull/15.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Apr 5, 2021

👋 Welcome back yan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport d6d5d9bf2f1a3343af6cf30a9d06a1f1b5f764ad 8261231: Windows IME was disabled after DnD operation Apr 5, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Apr 5, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

@openjdk openjdk bot commented Apr 5, 2021

@yan-too This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8261231: Windows IME was disabled after DnD operation

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 9 new commits pushed to the master branch:

  • 5bfa154: 8257988: Remove JNF dependency from libsaproc/MacosxDebuggerLocal.m
  • 4c91720: 8260616: Removing remaining JNF dependencies in the java.desktop module
  • 1f14066: 8259869: [macOS] Remove desktop module dependencies on JNF Reference APIs
  • efd22bb: 8259651: [macOS] Replace JNF_COCOA_ENTER/EXIT macros
  • e688dae: 8259343: [macOS] Update JNI error handling in Cocoa code.
  • 2798c72: 8257853: Remove dependencies on JNF's JNI utility functions in AWT and 2D code
  • e245349: 8240487: Cleanup whitespace in .cc, .hh, .m, and .mm files
  • 0da4bb8: 8257858: [macOS]: Remove JNF dependency from libosxsecurity/KeystoreImpl.m
  • c565a2b: 8256501: libTestMainKeyWindow fails to build with Xcode 12.2

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Apr 5, 2021

Webrevs

@yan-too
Copy link
Collaborator Author

@yan-too yan-too commented Apr 5, 2021

/integrate

@openjdk openjdk bot closed this Apr 5, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Apr 5, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Apr 5, 2021

@yan-too Since your change was applied there have been 9 commits pushed to the master branch:

  • 5bfa154: 8257988: Remove JNF dependency from libsaproc/MacosxDebuggerLocal.m
  • 4c91720: 8260616: Removing remaining JNF dependencies in the java.desktop module
  • 1f14066: 8259869: [macOS] Remove desktop module dependencies on JNF Reference APIs
  • efd22bb: 8259651: [macOS] Replace JNF_COCOA_ENTER/EXIT macros
  • e688dae: 8259343: [macOS] Update JNI error handling in Cocoa code.
  • 2798c72: 8257853: Remove dependencies on JNF's JNI utility functions in AWT and 2D code
  • e245349: 8240487: Cleanup whitespace in .cc, .hh, .m, and .mm files
  • 0da4bb8: 8257858: [macOS]: Remove JNF dependency from libosxsecurity/KeystoreImpl.m
  • c565a2b: 8256501: libTestMainKeyWindow fails to build with Xcode 12.2

Your commit was automatically rebased without conflicts.

Pushed as commit 0f9626c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@yan-too yan-too deleted the bp8261231 branch Apr 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant