Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8277224: sun.security.pkcs.PKCS9Attributes.toString() throws NPE #154

Closed
wants to merge 1 commit into from

Conversation

yan-too
Copy link
Collaborator

@yan-too yan-too commented Dec 20, 2021

Backport this fix to 15 where the original enhancement has been created.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8277224: sun.security.pkcs.PKCS9Attributes.toString() throws NPE

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk15u-dev pull/154/head:pull/154
$ git checkout pull/154

Update a local copy of the PR:
$ git checkout pull/154
$ git pull https://git.openjdk.java.net/jdk15u-dev pull/154/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 154

View PR using the GUI difftool:
$ git pr show -t 154

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk15u-dev/pull/154.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Dec 20, 2021

👋 Welcome back yan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 6bb04626af6574ef1e8d4b7dad0389d4b59f5d08 8277224: sun.security.pkcs.PKCS9Attributes.toString() throws NPE Dec 20, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Dec 20, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

@openjdk openjdk bot commented Dec 20, 2021

@yan-too This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8277224: sun.security.pkcs.PKCS9Attributes.toString() throws NPE

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 9beff4a: 8278997: Bump update version for OpenJDK: jdk-15.0.7

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready rfr labels Dec 20, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Dec 20, 2021

Webrevs

@yan-too
Copy link
Collaborator Author

@yan-too yan-too commented Dec 21, 2021

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Dec 21, 2021

Going to push as commit c53498b.
Since your change was applied there has been 1 commit pushed to the master branch:

  • 9beff4a: 8278997: Bump update version for OpenJDK: jdk-15.0.7

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated label Dec 21, 2021
@openjdk openjdk bot closed this Dec 21, 2021
@openjdk openjdk bot removed ready rfr labels Dec 21, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Dec 21, 2021

@yan-too Pushed as commit c53498b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated
1 participant