8279077: JFR crashes on Linux ppc due to missing crash protector in signal handler

[zhengyu123]

This is a linux_ppc specific bug, probably a day-one bug till relevant code was refactored by JDK-8255711 in 16.

Linux ppc signal handler does not install crash protector as other Linux based platforms do, e.g. linux_x86, that can result a crash while jfr tries to fill stack trace for other thread.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8279077: JFR crashes on Linux ppc due to missing crash protector in signal handler

Reviewers

• Paul Hohensee (@phohensee - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk15u-dev pull/155/head:pull/155
$ git checkout pull/155

Update a local copy of the PR:
$ git checkout pull/155
$ git pull https://git.openjdk.java.net/jdk15u-dev pull/155/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 155

View PR using the GUI difftool:
$ git pr show -t 155

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk15u-dev/pull/155.diff

[bridgekeeper]

👋 Welcome back zgu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[mlbridge]

Webrevs

• 00: Full (5a6b41c2)

[phohensee]

Please add the jdk16 and later comment:

// Handle JFR thread crash protection.
// Note: this may cause us to longjmp away. Do not use any code before this
// point which really needs any form of epilogue code running, eg RAII objects.

[zhengyu123]

Please add the jdk16 and later comment:

// Handle JFR thread crash protection. // Note: this may cause us to longjmp away. Do not use any code before this // point which really needs any form of epilogue code running, eg RAII objects.

If we want to update comments, we should do it cross all relevant platforms. This is a linux ppc specific bug, would you mind to update comments in separate CR?

Thanks,

[phohensee]

Fine with me, though note that all releases from 16 on have the same comment.

[openjdk]

@zhengyu123 This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8279077: JFR crashes on Linux ppc due to missing crash protector in signal handler

Reviewed-by: phh

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[zhengyu123]

Fine with me, though note that all releases from 16 on have the same comment.

Filed: JDK-8279181

[phohensee]

Thank you, Zhengyu.

[zhengyu123]

/integrate

[zhengyu123]

Got approval, integrated.

[openjdk]

Going to push as commit 250ef7d.

[openjdk]

@zhengyu123 Pushed as commit 250ef7d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.