Skip to content
This repository has been archived by the owner on Feb 2, 2023. It is now read-only.

8253639: Change os::attempt_reserve_memory_at parameter order #156

Closed
wants to merge 1 commit into from
Closed

8253639: Change os::attempt_reserve_memory_at parameter order #156

wants to merge 1 commit into from

Conversation

GlebSolovev
Copy link

@GlebSolovev GlebSolovev commented Jan 13, 2022

Clean backport of https://bugs.openjdk.java.net/browse/JDK-8253639: simple changing parameter order to improve code consistency.

Testing: tier1 on Linux x86 didn't regress.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8253639: Change os::attempt_reserve_memory_at parameter order ⚠️ Issue is not open.

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk15u-dev pull/156/head:pull/156
$ git checkout pull/156

Update a local copy of the PR:
$ git checkout pull/156
$ git pull https://git.openjdk.java.net/jdk15u-dev pull/156/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 156

View PR using the GUI difftool:
$ git pr show -t 156

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk15u-dev/pull/156.diff

Backport ca1ed16292492d256d076122d124be8978fce4c3
@bridgekeeper bridgekeeper bot added the oca Needs verification of OCA signatory status label Jan 13, 2022
@bridgekeeper
Copy link

bridgekeeper bot commented Jan 13, 2022

Hi @GlebSolovev, welcome to this OpenJDK project and thanks for contributing!

We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing /signed in a comment in this pull request.

If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user GlebSolovev" as summary for the issue.

If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing /covered in a comment in this pull request.

@GlebSolovev
Copy link
Author

/covered

@bridgekeeper bridgekeeper bot added the oca-verify Needs verification of OCA signatory status label Jan 13, 2022
@bridgekeeper
Copy link

bridgekeeper bot commented Jan 13, 2022

Thank you! Please allow for a few business days to verify that your employer has signed the OCA. Also, please note that pull requests that are pending an OCA check will not usually be evaluated, so your patience is appreciated!

@robilad
Copy link

robilad commented Jan 18, 2022

Hi Gleb, can you please send me an e-mail at Dalibor.topic@oracle.com so that I can mark your account as verified?

@bridgekeeper bridgekeeper bot removed oca Needs verification of OCA signatory status oca-verify Needs verification of OCA signatory status labels Feb 2, 2022
@openjdk openjdk bot added the rfr Pull request is ready for review label Feb 2, 2022
@mlbridge
Copy link

mlbridge bot commented Feb 2, 2022

Webrevs

@GlebSolovev
Copy link
Author

As a result of race-condition in out team, this change has already been made here: #168.
I'm sorry, I'm closing this pull request.

@GlebSolovev GlebSolovev closed this Feb 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
rfr Pull request is ready for review
2 participants