Skip to content
This repository has been archived by the owner on Feb 2, 2023. It is now read-only.

8274658: ISO 4217 Amendment 170 Update #157

Closed
wants to merge 1 commit into from

Conversation

yan-too
Copy link
Collaborator

@yan-too yan-too commented Jan 19, 2022

The backport is almost clean, two conflicts to adjust are in the lists of relevant bug IDs in tests.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk15u-dev pull/157/head:pull/157
$ git checkout pull/157

Update a local copy of the PR:
$ git checkout pull/157
$ git pull https://git.openjdk.java.net/jdk15u-dev pull/157/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 157

View PR using the GUI difftool:
$ git pr show -t 157

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk15u-dev/pull/157.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 19, 2022

👋 Welcome back yan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport f2404d60de2b58c590bf885f5cce50c289073673 8274658: ISO 4217 Amendment 170 Update Jan 19, 2022
@openjdk
Copy link

openjdk bot commented Jan 19, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Jan 19, 2022
@yan-too
Copy link
Collaborator Author

yan-too commented Jan 19, 2022

/clean

@mlbridge
Copy link

mlbridge bot commented Jan 19, 2022

Webrevs

@openjdk openjdk bot added the clean label Jan 19, 2022
@openjdk
Copy link

openjdk bot commented Jan 19, 2022

@yan-too This backport pull request is now marked as clean

@openjdk
Copy link

openjdk bot commented Jan 19, 2022

@yan-too This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8274658: ISO 4217 Amendment 170 Update

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jan 19, 2022
@yan-too
Copy link
Collaborator Author

yan-too commented Jan 19, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Jan 19, 2022

Going to push as commit 5e8d6a5.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 19, 2022
@openjdk openjdk bot closed this Jan 19, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 19, 2022
@openjdk
Copy link

openjdk bot commented Jan 19, 2022

@yan-too Pushed as commit 5e8d6a5.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@yan-too yan-too deleted the bp8274658 branch January 19, 2022 15:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport clean integrated Pull request has been integrated
1 participant