Skip to content
This repository was archived by the owner on Feb 2, 2023. It is now read-only.

8273359: CI: ciInstanceKlass::get_canonical_holder() doesn't respect instance size #159

Closed
wants to merge 2 commits into from

Conversation

yan-too
Copy link
Collaborator

@yan-too yan-too commented Jan 25, 2022

to fix the regression where it has been introduced.
The patch applies not exactly clean because of some context differences. The relevant tests run OK: the included test doesn't fail on 15u even before the fix:-(


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8273359: CI: ciInstanceKlass::get_canonical_holder() doesn't respect instance size

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk15u-dev pull/159/head:pull/159
$ git checkout pull/159

Update a local copy of the PR:
$ git checkout pull/159
$ git pull https://git.openjdk.java.net/jdk15u-dev pull/159/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 159

View PR using the GUI difftool:
$ git pr show -t 159

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk15u-dev/pull/159.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 25, 2022

👋 Welcome back yan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport f7e9f56e235dc50daae0a85c9790d5b04c9c60f0 8273359: CI: ciInstanceKlass::get_canonical_holder() doesn't respect instance size Jan 25, 2022
@openjdk
Copy link

openjdk bot commented Jan 25, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Jan 25, 2022
@mlbridge
Copy link

mlbridge bot commented Jan 25, 2022

Webrevs

Copy link
Collaborator

@bae bae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine.

@openjdk
Copy link

openjdk bot commented Jan 25, 2022

@yan-too This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8273359: CI: ciInstanceKlass::get_canonical_holder() doesn't respect instance size

Reviewed-by: bae

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jan 25, 2022
@yan-too
Copy link
Collaborator Author

yan-too commented Jan 25, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Jan 25, 2022

Going to push as commit a7a603c.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 25, 2022
@openjdk openjdk bot closed this Jan 25, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 25, 2022
@openjdk
Copy link

openjdk bot commented Jan 25, 2022

@yan-too Pushed as commit a7a603c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@yan-too yan-too deleted the bp8273359 branch January 25, 2022 09:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants