-
Notifications
You must be signed in to change notification settings - Fork 30
8273359: CI: ciInstanceKlass::get_canonical_holder() doesn't respect instance size #159
Conversation
👋 Welcome back yan! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issue from the original commit. |
Webrevs
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine.
@yan-too This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
/integrate |
Going to push as commit a7a603c. |
to fix the regression where it has been introduced.
The patch applies not exactly clean because of some context differences. The relevant tests run OK: the included test doesn't fail on 15u even before the fix:-(
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk15u-dev pull/159/head:pull/159
$ git checkout pull/159
Update a local copy of the PR:
$ git checkout pull/159
$ git pull https://git.openjdk.java.net/jdk15u-dev pull/159/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 159
View PR using the GUI difftool:
$ git pr show -t 159
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk15u-dev/pull/159.diff