Skip to content
This repository has been archived by the owner on Feb 2, 2023. It is now read-only.

8259535: ECDSA SignatureValue do not always have the specified length #161

Closed
wants to merge 2 commits into from

Conversation

yan-too
Copy link
Collaborator

@yan-too yan-too commented Jan 27, 2022

First in a chain of updating 15u to newer Santuario. Applies cleanly but in the test printout at he line 91 must be changed for older jdk15u.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8259535: ECDSA SignatureValue do not always have the specified length

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk15u-dev pull/161/head:pull/161
$ git checkout pull/161

Update a local copy of the PR:
$ git checkout pull/161
$ git pull https://git.openjdk.java.net/jdk15u-dev pull/161/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 161

View PR using the GUI difftool:
$ git pr show -t 161

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk15u-dev/pull/161.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 27, 2022

👋 Welcome back yan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport a4c249610e7c0fcc7fd863f14f51c96abc5ca39f 8259535: ECDSA SignatureValue do not always have the specified length Jan 27, 2022
@openjdk
Copy link

openjdk bot commented Jan 27, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added the backport label Jan 27, 2022
@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 27, 2022
@mlbridge
Copy link

mlbridge bot commented Jan 27, 2022

Webrevs

Copy link
Collaborator

@bae bae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably the statement System.out.print(String.format()) can be replaced with System.out.printf(), but current version is in sync with 11u.

The change looks fine to me.

@openjdk
Copy link

openjdk bot commented Jan 27, 2022

@yan-too This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8259535: ECDSA SignatureValue do not always have the specified length

Reviewed-by: bae

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 04766a0: 8273341: Update Siphash to version 1.0

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jan 27, 2022
@yan-too
Copy link
Collaborator Author

yan-too commented Jan 27, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Jan 27, 2022

Going to push as commit 4bb9d4b.
Since your change was applied there has been 1 commit pushed to the master branch:

  • 04766a0: 8273341: Update Siphash to version 1.0

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 27, 2022
@openjdk openjdk bot closed this Jan 27, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 27, 2022
@openjdk
Copy link

openjdk bot commented Jan 27, 2022

@yan-too Pushed as commit 4bb9d4b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@yan-too yan-too deleted the sa8259535 branch January 27, 2022 11:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport integrated Pull request has been integrated
2 participants