8250902: Implement MD5 Intrinsics on x86

[phohensee]

I'd like to backport MD5 intrinsification because it improves security related performance. Backport is clean except for a merge conflict in library_call.cpp resulting from renumbering the intrinsic enum.

This backport will be immediately followed by a backport of JDK-8251260 to fix two tests. After that, I'd like to backport the aarch64 version in JDK-8251216.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8250902: Implement MD5 Intrinsics on x86

Reviewers

• Ludovic Henry (@luhenry - no project role)
• Volker Simonis (@simonis - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk15u-dev pull/163/head:pull/163
$ git checkout pull/163

Update a local copy of the PR:
$ git checkout pull/163
$ git pull https://git.openjdk.java.net/jdk15u-dev pull/163/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 163

View PR using the GUI difftool:
$ git pr show -t 163

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk15u-dev/pull/163.diff

[bridgekeeper]

👋 Welcome back phh! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[mlbridge]

Webrevs

• 00: Full (4d64e48e)

[phohensee]

Thank you for the review, Ludovic.

Testing: tier1, including the new and existing sha tests.

[simonis]

Looks good to me.

Just for reference, I want to mention that the merge conflict in library_call.cpp is because 8151779: Some intrinsic flags could be replaced with one general flag is missing in JDK 15, but it obviously doesn't make sense to downport that huge change as a dependency for this downport.

Thanks,
Volker

[openjdk]

@phohensee This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8250902: Implement MD5 Intrinsics on x86

Reviewed-by: luhenry, simonis

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[phohensee]

Thanks for the review, Volker. I agree on 8151779.

[phohensee]

Backport approved.

/integrate

[openjdk]

Going to push as commit 6a904b3.
Since your change was applied there have been 2 commits pushed to the master branch:

• feac56e: 8275082: Update XML Security for Java to 2.3.0
• e95ff4d: 8280414: Memory leak in DefaultProxySelector

Your commit was automatically rebased without conflicts.

[openjdk]

@phohensee Pushed as commit 6a904b3.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.