Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8251260: two MD5 tests fail "RuntimeException: Unexpected count of intrinsic" #166

Closed
wants to merge 1 commit into from

Conversation

phohensee
Copy link
Member

@phohensee phohensee commented Jan 31, 2022

I'd like to backport this as a necessary follow-up to JDK-8280978, which latter is the 15u backport of JDK-8250902.

Applies cleanly, test-only fix that disables MD5/SHA tests for AOT.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8251260: two MD5 tests fail "RuntimeException: Unexpected count of intrinsic"

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk15u-dev pull/166/head:pull/166
$ git checkout pull/166

Update a local copy of the PR:
$ git checkout pull/166
$ git pull https://git.openjdk.java.net/jdk15u-dev pull/166/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 166

View PR using the GUI difftool:
$ git pr show -t 166

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk15u-dev/pull/166.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 31, 2022

👋 Welcome back phh! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 1ad165941313bbaa9e886946081c321f35374f6e 8251260: two MD5 tests fail "RuntimeException: Unexpected count of intrinsic" Jan 31, 2022
@openjdk
Copy link

openjdk bot commented Jan 31, 2022

This backport pull request has now been updated with issue and summary from the original commit.

@openjdk
Copy link

openjdk bot commented Jan 31, 2022

@phohensee This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8251260: two MD5 tests fail "RuntimeException: Unexpected count of intrinsic"

Do not run intrinsics/sha/sanity tests with AOTed java.base

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 31, 2022
@mlbridge
Copy link

mlbridge bot commented Jan 31, 2022

Webrevs

@phohensee phohensee marked this pull request as draft Jan 31, 2022
@openjdk openjdk bot removed the rfr Pull request is ready for review label Jan 31, 2022
@phohensee phohensee marked this pull request as ready for review Jan 31, 2022
@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 31, 2022
@phohensee
Copy link
Member Author

phohensee commented Feb 1, 2022

Patch approved.

/integrate

@openjdk
Copy link

openjdk bot commented Feb 1, 2022

Going to push as commit 7bf914d.

@openjdk openjdk bot added the integrated Pull request has been integrated label Feb 1, 2022
@openjdk openjdk bot closed this Feb 1, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Feb 1, 2022
@openjdk
Copy link

openjdk bot commented Feb 1, 2022

@phohensee Pushed as commit 7bf914d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@phohensee phohensee deleted the backport-1ad16594 branch Feb 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant