Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8251216: Implement MD5 intrinsics on AArch64 #167

Closed
wants to merge 1 commit into from

Conversation

phohensee
Copy link
Member

@phohensee phohensee commented Feb 1, 2022

This backport completes the series whose prefix is JDK-8250902 and JDK-8251260. See https://git.openjdk.java.net/jdk15u-dev/pull/163 and https://git.openjdk.java.net/jdk15u-dev/pull/166 respectively.

The backport is clean except for a minor conflict in stubRoutines_aarch64.hpp, where code_size2 is changed to 45000.

Testing: tier1, including MD5/SHA jtreg tests.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk15u-dev pull/167/head:pull/167
$ git checkout pull/167

Update a local copy of the PR:
$ git checkout pull/167
$ git pull https://git.openjdk.java.net/jdk15u-dev pull/167/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 167

View PR using the GUI difftool:
$ git pr show -t 167

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk15u-dev/pull/167.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Feb 1, 2022

👋 Welcome back phh! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 088b244ec6d9393a1fcd2233fa5b4cf46f9ae0dd 8251216: Implement MD5 intrinsics on AArch64 Feb 1, 2022
@openjdk
Copy link

@openjdk openjdk bot commented Feb 1, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr labels Feb 1, 2022
@mlbridge
Copy link

@mlbridge mlbridge bot commented Feb 1, 2022

Webrevs

simonis
simonis approved these changes Feb 2, 2022
Copy link
Member

@simonis simonis left a comment

Looks good to me. The new code size is probably a little to high because in 18 there are additional stubs which haven't been downported yet, but better be on the safe side :)

@openjdk
Copy link

@openjdk openjdk bot commented Feb 2, 2022

@phohensee This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8251216: Implement MD5 intrinsics on AArch64

Reviewed-by: simonis

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Feb 2, 2022
@phohensee
Copy link
Member Author

@phohensee phohensee commented Feb 2, 2022

That's what I thought too. Also, it's a tiny bit less different from the original patch to leave it at 45000. Thanks for the review!

@phohensee
Copy link
Member Author

@phohensee phohensee commented Feb 2, 2022

Approved.

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Feb 2, 2022

Going to push as commit 2802620.

@openjdk openjdk bot added the integrated label Feb 2, 2022
@openjdk openjdk bot closed this Feb 2, 2022
@openjdk openjdk bot removed ready rfr labels Feb 2, 2022
@openjdk
Copy link

@openjdk openjdk bot commented Feb 2, 2022

@phohensee Pushed as commit 2802620.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@phohensee phohensee deleted the backport-088b244e branch Feb 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated
2 participants