-
Notifications
You must be signed in to change notification settings - Fork 30
8251216: Implement MD5 intrinsics on AArch64 #167
Conversation
👋 Welcome back phh! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issue from the original commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. The new code size is probably a little to high because in 18 there are additional stubs which haven't been downported yet, but better be on the safe side :)
@phohensee This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
That's what I thought too. Also, it's a tiny bit less different from the original patch to leave it at 45000. Thanks for the review! |
Approved. /integrate |
Going to push as commit 2802620. |
@phohensee Pushed as commit 2802620. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
This backport completes the series whose prefix is JDK-8250902 and JDK-8251260. See https://git.openjdk.java.net/jdk15u-dev/pull/163 and https://git.openjdk.java.net/jdk15u-dev/pull/166 respectively.
The backport is clean except for a minor conflict in stubRoutines_aarch64.hpp, where code_size2 is changed to 45000.
Testing: tier1, including MD5/SHA jtreg tests.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk15u-dev pull/167/head:pull/167
$ git checkout pull/167
Update a local copy of the PR:
$ git checkout pull/167
$ git pull https://git.openjdk.java.net/jdk15u-dev pull/167/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 167
View PR using the GUI difftool:
$ git pr show -t 167
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk15u-dev/pull/167.diff