Skip to content
This repository has been archived by the owner on Feb 2, 2023. It is now read-only.

8253639: Change os::attempt_reserve_memory_at parameter order #168

Closed
wants to merge 1 commit into from

Conversation

KaperD
Copy link
Contributor

@KaperD KaperD commented Feb 2, 2022

This backport is a part of MacOS/aarch64 support backport. It is needed to backport JDK-8234930.

It has been tested (tier1) on Linux x64 and x86, on Windows x64 and on MacOS x64 (https://github.com/KaperD/jdk15u-dev/actions/runs/1769438706)


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8253639: Change os::attempt_reserve_memory_at parameter order

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk15u-dev pull/168/head:pull/168
$ git checkout pull/168

Update a local copy of the PR:
$ git checkout pull/168
$ git pull https://git.openjdk.java.net/jdk15u-dev pull/168/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 168

View PR using the GUI difftool:
$ git pr show -t 168

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk15u-dev/pull/168.diff

Backport ca1ed16292492d256d076122d124be8978fce4c3
@bridgekeeper
Copy link

bridgekeeper bot commented Feb 2, 2022

👋 Welcome back KaperD! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Feb 2, 2022
@mlbridge
Copy link

mlbridge bot commented Feb 2, 2022

Webrevs

@KaperD KaperD changed the title 8253639: Change os::attempt_reserve_memory_at parameter order Backport ca1ed16292492d256d076122d124be8978fce4c3 Feb 2, 2022
@openjdk openjdk bot changed the title Backport ca1ed16292492d256d076122d124be8978fce4c3 8253639: Change os::attempt_reserve_memory_at parameter order Feb 2, 2022
@openjdk
Copy link

openjdk bot commented Feb 2, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Feb 2, 2022

@KaperD This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8253639: Change os::attempt_reserve_memory_at parameter order

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 5 new commits pushed to the master branch:

  • 2802620: 8251216: Implement MD5 intrinsics on AArch64
  • 7bf914d: 8251260: two MD5 tests fail "RuntimeException: Unexpected count of intrinsic"
  • 6a904b3: 8250902: Implement MD5 Intrinsics on x86
  • feac56e: 8275082: Update XML Security for Java to 2.3.0
  • e95ff4d: 8280414: Memory leak in DefaultProxySelector

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Feb 2, 2022
@KaperD
Copy link
Contributor Author

KaperD commented Feb 3, 2022

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Feb 3, 2022
@openjdk
Copy link

openjdk bot commented Feb 3, 2022

@KaperD
Your change (at version 6402b14) is now ready to be sponsored by a Committer.

@yan-too
Copy link
Collaborator

yan-too commented Feb 3, 2022

/sponsor

@openjdk
Copy link

openjdk bot commented Feb 3, 2022

Going to push as commit 7894815.
Since your change was applied there have been 5 commits pushed to the master branch:

  • 2802620: 8251216: Implement MD5 intrinsics on AArch64
  • 7bf914d: 8251260: two MD5 tests fail "RuntimeException: Unexpected count of intrinsic"
  • 6a904b3: 8250902: Implement MD5 Intrinsics on x86
  • feac56e: 8275082: Update XML Security for Java to 2.3.0
  • e95ff4d: 8280414: Memory leak in DefaultProxySelector

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Feb 3, 2022
@openjdk openjdk bot closed this Feb 3, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Feb 3, 2022
@openjdk
Copy link

openjdk bot commented Feb 3, 2022

@yan-too @KaperD Pushed as commit 7894815.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport clean integrated Pull request has been integrated
2 participants